Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change severity of log entries in sftp-subsys.log #25

Open
Bjarke42 opened this issue Sep 12, 2023 · 1 comment
Open

Change severity of log entries in sftp-subsys.log #25

Bjarke42 opened this issue Sep 12, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Bjarke42
Copy link

Bjarke42 commented Sep 12, 2023

The following log entries from sftp.subsys.log:

2023-09-12 09:00:53,526 ERROR get_fs_path failed: Invalid path characters

another

2023-09-12 09:00:53,526 WARNING lstat filepath/filename: Invalid path characters

Please set those to only being shown if debug is enabled, they serve no purpose to see on a system. They are from a user who does not use the system correctly, that should not reflect as an error on the server, nor a warning with a full printout of the fil.

Just for some perspective, this is the amount i have for this month in the log file:

# grep "ERROR get_fs_path failed:" sftp-subsys.log |wc -l
15317317
# grep ": Invalid path characters" sftp-subsys.log |wc -l
30809002
# wc -l sftp-subsys.log
45424166 sftp-subsys.log

68% of the logfile is these two entries alone, from a user who does not check his replication errors.

@jonasbardino jonasbardino added the enhancement New feature or request label Sep 12, 2023
@jonasbardino
Copy link
Contributor

While the log volume sounds (too) high I disagree that incorrect use errors are ever irrelevant. When time permits we can look into reducing the verbosity and maybe reduce error to warning, but I don't think changing such logs to debug is the right solution.
Educating users or filtering logs are valid alternatives. Perhaps investigating which invalid path characters it revolves around would be another idea. We are conservative about not allowing characters that may be harmful or cause cross-platform inconsistencies, but are still open to adjusting to allow safe valid use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants