Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output gradually scales up over time #32

Open
samcrow opened this issue May 26, 2022 · 0 comments
Open

Output gradually scales up over time #32

samcrow opened this issue May 26, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@samcrow
Copy link
Collaborator

samcrow commented May 26, 2022

We've seen that the time-domain reconstructed samples gradually increase in magnitude over several seconds.

This line in the frequency correct step might have a small problem: https://github.com/ucsdsysnet/sparsdr/blob/master/reconstruct/src/steps/frequency_correct.rs#L67

The magnitude of self.correction is supposed to always be 1, but because of math errors its magnitude might gradually increase.

I saw somewhere that someone was doing self.correction = self.correction / self.correction.norm() periodically (not for every sample) to keep the magnitude close to 1.

@samcrow samcrow added the bug Something isn't working label May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant