Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S12.01-Exercise-DimensionsColorsAndFonts #212

Open
HasanElHefnawy opened this issue Sep 12, 2019 · 0 comments
Open

S12.01-Exercise-DimensionsColorsAndFonts #212

HasanElHefnawy opened this issue Sep 12, 2019 · 0 comments

Comments

@HasanElHefnawy
Copy link

These entries were added in dimens.xml, but never used:
today_icon
list_item_icon_margin_end
loading_indicator_size
list_item_high_temperature_margin
list_item_low_temperature_text_view_size

These entries have ambiguous names and need to be named clearly:
forecast_temperature_space (should be named list_item_high_temperature_margin)
forecast_text_size (should be named list_item_temperature_text_view_size)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant