Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.21 version? #38

Open
deathclonic opened this issue Nov 14, 2018 · 5 comments
Open

4.21 version? #38

deathclonic opened this issue Nov 14, 2018 · 5 comments

Comments

@deathclonic
Copy link

Will this ever get an update?

@Korniow
Copy link

Korniow commented Jan 6, 2019

Created a PR for that #41

@bbbb951
Copy link

bbbb951 commented Jan 7, 2019

@Korniow Thanks you very much! This is what i have looking for a month! Could you tell me how to update the plugin for the newest enging version , Or show me a guide link for it. I will very appericiate for your kindly help.

@Korniow
Copy link

Korniow commented Jan 7, 2019

@bbbb951 Yesterday two older pull requests were merged. You can wait for @nickdarnell to merge also my PR, then clone this repository into your projects Plugin folder and build it. See https://github.com/ue4plugins/LoadingScreen#usage

@bbbb951
Copy link

bbbb951 commented Jan 8, 2019

@Korniow Thank you for your kindly reply. Sorry,It seems that i mislead you. Basically, I know how to update the plugin of my project by using the PR you create. And what I wonder is how to create a PR for the plugin to make is suitable for the latest enging (maybe 4.22 or 4.23 and so on).So could you offer me some advice about this ? Thanks again.

@Korniow
Copy link

Korniow commented Jan 8, 2019

If you need to know what changes were made in the newest version of UE4, then you need to look at detailed release notes https://docs.unrealengine.com/en-us/Builds/4_21 where you will find removed and deprecated functionalities. You can also build the plugin using the newest version of UE4 and see what errors are contained in the build log.

Then you need to fork the https://github.com/ue4plugins/LoadingScreen repository to have your own copy of it. Clone your fork and create a branch with necessary changes. Commit and push it to your fork. Then go to https://github.com/ue4plugins/LoadingScreen/pulls and click "New pull request" button. Pick the branch with your changes and thats basically it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants