Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong frame duration when playing real time stream #64

Open
YouRancestor opened this issue Mar 26, 2019 · 1 comment
Open

Wrong frame duration when playing real time stream #64

YouRancestor opened this issue Mar 26, 2019 · 1 comment

Comments

@YouRancestor
Copy link

YouRancestor commented Mar 26, 2019

libvlc_media_player_get_fps(aka FVlc::MediaPlayerGetFps) may returns a 0.0f if the fps is unspecified in some real time streams.
And the current code use its return value as denominator without check when caculating VideoFrameDuration. This can lead to an error that Engine cannot get pictures correctly from the sample pool because of the wrong duration.
Just check fps and set frame duration to 1 millisecond if fps is not greater than 0.0f can resolve this problem.

@nzx824
Copy link

nzx824 commented Oct 8, 2019

666666,"picture is too late to be displayed" can also repair by this code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants