Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/find mtk steady state #69

Merged
merged 22 commits into from
Sep 1, 2024

Conversation

1-Bart-1
Copy link
Collaborator

Add a MTK steady state finder, and remove the kps4_3l residual model.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 94.32314% with 13 lines in your changes missing coverage. Please review.

Project coverage is 87.42%. Comparing base (c50bbe8) to head (b7d1ce5).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/KPS4_3L.jl 95.77% 9 Missing ⚠️
src/KiteModels.jl 69.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   94.80%   87.42%   -7.39%     
==========================================
  Files           6        5       -1     
  Lines        1540     1272     -268     
==========================================
- Hits         1460     1112     -348     
- Misses         80      160      +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ufechner7
Copy link
Owner

I checked out your branch locally and tried to create a fresh system image. I get the following error message

[ Info: PackageCompiler: Executing /home/ufechner/repos/KiteModels.jl/test/test_for_precompile.jl => /tmp/jl_packagecompiler_TJF8dw/jl_65cPoA
Running models
ERROR: LoadError: MethodError: no method matching init_sim!(::KPS4_3L{Float64, StaticArraysCore.MVector{3, Float64}, 24, 24, KiteModels.Spring{Int16, Float64}}; stiffness_factor::Float64, prn::Bool, mtk::Bool, torque_control::Bool)

Closest candidates are:
  init_sim!(::KPS4_3L; t_end, stiffness_factor, prn, torque_control) got unsupported keyword argument "mtk"
   @ KiteModels ~/repos/KiteModels.jl/src/KPS4_3L.jl:328
  init_sim!(::KiteModels.AbstractKiteModel; t_end, stiffness_factor, delta, prn) got unsupported keyword arguments "mtk", "torque_control"
   @ KiteModels ~/repos/KiteModels.jl/src/KiteModels.jl:501

Stacktrace:
 [1] kwerr(::@NamedTuple{stiffness_factor::Float64, prn::Bool, mtk::Bool, torque_control::Bool}, ::Function, ::KPS4_3L{Float64, StaticArraysCore.MVector{3, Float64}, 24, 24, KiteModels.Spring{Int16, Float64}})
   @ Base ./error.jl:165
 [2] top-level scope
   @ ~/repos/KiteModels.jl/test/test_for_precompile.jl:121
in expression starting at /home/ufechner/repos/KiteModels.jl/test/test_for_precompile.jl:102

Can you fix that?

@ufechner7 ufechner7 merged commit e93d368 into ufechner7:main Sep 1, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants