Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issues in w0_d3 #127

Open
nickv779 opened this issue Oct 3, 2024 · 1 comment
Open

Fix Issues in w0_d3 #127

nickv779 opened this issue Oct 3, 2024 · 1 comment
Assignees

Comments

@nickv779
Copy link
Collaborator

nickv779 commented Oct 3, 2024

In w0_d3.rpy, there are a few issues that lead to inconsistency with the rest of the game. This is semi-urgent, so please work quickly to adjust the code before it gets piled up with more problems.

Problems

In label w0_d3, the MC wakes up and thinks to himself a few comments. These should NOT have quotes, as these are thoughts and not spoken words. The first fix will remove the escaped quotation marks here.

In menus choosingLastClass and w0d3_talktopython, the choices are in all caps. This shouldn't be the case, please rewrite them to be proper. Here's an example of a fix:

GO HOME >> Go home

Instructions

When making the pull request, please reference this issue so it is autolinked. Furthermore, ensure every issue asked about is addressed, and that there is nothing missed. I will do a final review of the changes, and will reject them if I notice anything missing. LGTM

@nickv779 nickv779 assigned nickv779 and unassigned nickv779 Oct 3, 2024
@Gabriel-Munoz
Copy link
Contributor

hey can I have this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants