Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-structure code source #21

Open
igniscyan opened this issue Jan 23, 2019 · 1 comment
Open

Re-structure code source #21

igniscyan opened this issue Jan 23, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested

Comments

@igniscyan
Copy link
Contributor

For the sake of keeping the project easy to work with/contribute to, I think it's worth restructuring how we're keeping source files for now. A good example we can try and follow is located at this link

If I get approval to work on this, I'll look into getting Docker to work with the new layout as well.

@igniscyan igniscyan added enhancement New feature or request good first issue Good for newcomers question Further information is requested labels Jan 23, 2019
@mirdaki
Copy link
Member

mirdaki commented Jan 28, 2019

I haven't thoroughly looked through it yet, but it seems to be a good example (though a little more complex than we might need).

I wanted to add we should switch to using more dependency injection, at least with the models to use the database connection. This makes the architecture a little more clean and much more testable (tests fail now because there is no database to connect to).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants