Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting and build failure with actions #89

Open
swiftlee opened this issue Sep 11, 2020 · 1 comment
Open

Linting and build failure with actions #89

swiftlee opened this issue Sep 11, 2020 · 1 comment

Comments

@swiftlee
Copy link
Contributor

Add an ESLint configuration (we can come up with some general rules for our code if needed).

Integrate this with GitHub actions such that feature branches will fail actions on linting errors.

Master branch will fail to deploy and build on linting errors.

@up16
Copy link

up16 commented Sep 25, 2021

I can work on this one. I have a question, can we add pre-commit hook to check for linting errors and auto fix errors (where possible) before making a commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants