Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .animate syntax for MArray mutators #2

Open
Nikhil-42 opened this issue Mar 2, 2023 · 1 comment
Open

Support .animate syntax for MArray mutators #2

Nikhil-42 opened this issue Mar 2, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Nikhil-42
Copy link
Collaborator

Description

Remove explicit Animation construction in mutators or move the animation code to a method decorator to support .animate syntax.

@Nikhil-42 Nikhil-42 added the enhancement New feature or request label Mar 2, 2023
@Nikhil-42 Nikhil-42 changed the title Support .animate syntax for mutators Support .animate syntax for MArray mutators Mar 2, 2023
@Nikhil-42
Copy link
Collaborator Author

Here is an example of a typical refactor:

  1. Remove animation parameters from method signature.
  2. Return a self-reference (for method chaining).
  3. Extract mutation logic from animation function.
  4. Remove animations, references to self.__scene, internal functions, etc.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant