Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[production/RRFS.v1] update deep soil temperature of RUC LSM #217

Conversation

haiqinli
Copy link
Collaborator

Update the RUC LSM deep soil temperature from climatology to real forecast.

@grantfirl
Copy link
Collaborator

@haiqinli Is there a good reason to not include these changes in #211?

@haiqinli
Copy link
Collaborator Author

@haiqinli Is there a good reason to not include these changes in #211?
@grantfirl Per our discussion with Ming and Curtis, we will split the PR #211 into two seperate PRs. The new PR #217 only includes the FMS and minor RUC LSM deep soil temperature updates, and this new PR could be merged into RRFS.v1 easily. The smoke updates will be kept in the original PR #211. However, we need to do some retro runs to guarantee there will be very minor impacts on the meteorology forecast, and may take more time. Thanks.

@grantfirl
Copy link
Collaborator

@haiqinli Is there a good reason to not include these changes in #211?
@grantfirl Per our discussion with Ming and Curtis, we will split the PR #211 into two seperate PRs. The new PR #217 only includes the FMS and minor RUC LSM deep soil temperature updates, and this new PR could be merged into RRFS.v1 easily. The smoke updates will be kept in the original PR #211. However, we need to do some retro runs to guarantee there will be very minor impacts on the meteorology forecast, and may take more time. Thanks.

OK, sounds good. Thanks for the clarification.

@jkbk2004
Copy link

jkbk2004 commented Jul 3, 2024

Tests all completed at ufs-community/ufs-weather-model#2343. @grantfirl @dustinswales You can go ahead to merge this pr.

@dustinswales dustinswales merged commit 4128e06 into ufs-community:production/RRFS.v1 Jul 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants