Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fourth reconciliation PR from production/RRFS.v1 #230

Open
wants to merge 6 commits into
base: ufs/dev
Choose a base branch
from
Open

Fourth reconciliation PR from production/RRFS.v1 #230

wants to merge 6 commits into from

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Oct 29, 2024 •
edited
Loading

This work corresponds to #180, except it is targeted at ufs/dev.

  1. Update the MYNN PBL scheme for the RRFS.v1 code freeze.
  2. Update the Smoke modules for the RRFS.v1.
  3. Include the PR [production/RRFS.v1] fix zero cloud fraction for RRFS ensemble members  #186.

@grantfirl grantfirl marked this pull request as ready for review November 13, 2024 15:45
This was referenced Nov 13, 2024
Open
Open
climbfuji
climbfuji approved these changes Nov 18, 2024
View reviewed changes
Copy link

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at the sgs and mynn changes, thanks for cleaning up the code around qkemin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiqinli haiqinli haiqinli approved these changes

@joeolson42 joeolson42 joeolson42 approved these changes

@dustinswales dustinswales dustinswales approved these changes

@rhaesung rhaesung rhaesung approved these changes

@climbfuji climbfuji climbfuji approved these changes

@Qingfu-Liu Qingfu-Liu Awaiting requested review from Qingfu-Liu Qingfu-Liu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@grantfirl @climbfuji @rhaesung @dustinswales @joeolson42 @haiqinli