Upgrade to spack-stack-1.7.0 #1070
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkavulich
reviewed
Apr 16, 2024
|
|
||
| load(pathJoin("stack-intel", os.getenv("stack_intel_ver") or "2021.10.0")) | ||
| load(pathJoin("stack-cray-mpich", os.getenv("stack_cray_mpich_ver") or "8.1.25")) | ||
| load(pathJoin("cmake", os.getenv("cmake_ver") or "3.26.3")) | ||
| load(pathJoin("cmake", os.getenv("cmake_ver") or "3.23.1")) |
There was a problem hiding this comment.
Is there a reason for this CMake version downgrade?
There was a problem hiding this comment.
@mkavulich, just used cmake build by spack-stack vs. using one built by admins. It was to be consistent with other machines which use spack-stack built cmake (3.23.1).
For Derecho, we can go with 3.26.3 if needed.
There was a problem hiding this comment.
Thanks for the explanation, I didn't realize we were previously using the platform build instead of through spack. It's not necessary, I was just curious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
We have new version of spack-stack available. This pull request make sure we load correct modules for SRW.
Type of change
TESTS CONDUCTED:
DEPENDENCIES:
N/A
DOCUMENTATION:
N/A
ISSUE:
Solves issue #1069
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR: