-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main_aqm] fix: persistence flag always evaluates to false #1148
base: main_aqm
Are you sure you want to change the base?
[main_aqm] fix: persistence flag always evaluates to false #1148
Conversation
ush/interp_tools.py
Outdated
@@ -25,7 +25,7 @@ def date_range(current_day, ebb_dcycle, persistence): | |||
|
|||
if ebb_dcycle == 1: | |||
print('Find RAVE for ebb_dcyc 1') | |||
if persistence == True: | |||
if persistence: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JohanaRomeroAlvarez - The persistence
block is now entered. I attached a smoke_dust
log smoke_dust_2019072200.log that shows this. It probably makes sense for you to test, since I'm not sure what behavior is expected. Mostly I'm wondering if persistence should apply on the first day and the dummy emissions file should be input: First day true, no RAVE files available. Use dummy emissions file
.
DESCRIPTION OF CHANGES:
The
persistence
argument togenerate_fire_emissions.py
is passed as a string but evaluated against a boolean value in the script. This causes the flag to always evaluate toFalse
regardless of the flag value. Issue is fixed by converting the string to a boolean.Type of change
TESTS CONDUCTED:
DEPENDENCIES:
DOCUMENTATION:
ISSUE:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):