Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main_aqm] fix: persistence flag always evaluates to false #1148

Draft
wants to merge 7 commits into
base: main_aqm
Choose a base branch
from

Conversation

BenKoziol-NOAA
Copy link
Collaborator

@BenKoziol-NOAA BenKoziol-NOAA commented Nov 1, 2024

DESCRIPTION OF CHANGES:

The persistence argument to generate_fire_emissions.py is passed as a string but evaluated against a boolean value in the script. This causes the flag to always evaluate to False regardless of the flag value. Issue is fixed by converting the string to a boolean.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

TESTS CONDUCTED:

  • derecho.intel
  • gaea.intel
  • hera.gnu
  • hera.intel
  • hercules.intel
  • jet.intel
  • orion.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

DOCUMENTATION:

ISSUE:

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

CONTRIBUTORS (optional):

@BenKoziol-NOAA BenKoziol-NOAA changed the title [main_aqm] fix: persistence flag always evaluated to false [main_aqm] fix: persistence flag always evaluates to false Nov 1, 2024
@@ -25,7 +25,7 @@ def date_range(current_day, ebb_dcycle, persistence):

if ebb_dcycle == 1:
print('Find RAVE for ebb_dcyc 1')
if persistence == True:
if persistence:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohanaRomeroAlvarez - The persistence block is now entered. I attached a smoke_dust log smoke_dust_2019072200.log that shows this. It probably makes sense for you to test, since I'm not sure what behavior is expected. Mostly I'm wondering if persistence should apply on the first day and the dummy emissions file should be input: First day true, no RAVE files available. Use dummy emissions file.

@BenKoziol-NOAA BenKoziol-NOAA self-assigned this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant