Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atm-Lnd tests are not using V2 surface files #2267

Open
DeniseWorthen opened this issue May 6, 2024 · 5 comments · May be fixed by #2387
Open

Atm-Lnd tests are not using V2 surface files #2267

DeniseWorthen opened this issue May 6, 2024 · 5 comments · May be fixed by #2387
Labels
bug Something isn't working

Comments

@DeniseWorthen
Copy link
Collaborator

Description

The atm-lnd tests (control_p8_atmlnd,control_p8_atmlnd_sbs and control_restart_p8_atmlnd_) should be using V2 surface files

ufs-weather-model/tests/tests/control_p8_atmlnd

Line 207 in 26cb9e6

export V2_SFC_FILE=true

The v2 files are indicated by a global attribute in the sfc data file

// global attributes:
		:file_version = "V2" ;

The current tests do not show this attribute for the files in the INPUT directory.

To Reproduce:

Run any of the atm-lnd tests, and view the global attribute in the relevant files.

It appears from the run log run_control_p8_atmlnd_intel.log that the correct files are copied in but then later over-written. First INPUT_L127_v2_sfc/sfc_data.tile1.nc is copied but then later INPUT_L127/sfc_data.tile1.nc is also copied to INPUT.

See run-log here /glade/work/worthen/ufs-weather-model/tests/logs/log_derecho/run_control_p8_atmlnd_intel.log

Additional context

First seen during testing for Issue #2232

Output
@DeniseWorthen DeniseWorthen added the bug Something isn't working label May 6, 2024
@DeniseWorthen
Copy link
Collaborator Author

@uturuncoglu Would you check whether the run-scripts are using the correct input-data for these tests? Thanks.

@uturuncoglu
Copy link
Collaborator

@DeniseWorthen Okay. Let me check. I am not sure why they are overwritten.

@uturuncoglu
Copy link
Collaborator

@DeniseWorthen Okay. I think I found the issue. It seems that fv3_conf/noahmp_run.IN file overwrites it. That file does not have V2 file modification. It was just for running land with different resolution and there could be some kind of logical issue in there. I think that the fix only includes changes in the fv3_conf/noahmp_run.IN file. I'll update you soon.

@uturuncoglu
Copy link
Collaborator

@DeniseWorthen with V2 files the case is hanging. I need to look at carefully why. I think at this point tests are running with the mixture of files without issue.

@DeniseWorthen
Copy link
Collaborator Author

OK. Thanks for the update.

@uturuncoglu uturuncoglu mentioned this issue Jul 1, 2024
Open
@uturuncoglu uturuncoglu linked a pull request Jan 2, 2025 that will close this issue
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
ufs-community User Support
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates for component NoahMP land model uturuncoglu/ufs-weather-model
2 participants
@uturuncoglu @DeniseWorthen