[DRAFT] Remove local copies of FindESMF from all components, update ESMF to 8.6.1 and MAPL to 2.46.3 #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DusanJovic-NOAA If you are testing this with the head of the develop branch from GOCART (hash bf5cf04) then you need to update the Specifically this line It will need to be changed with I have a copy of this new file on hera: Once you have this I think your problems with updating gocart will be solved |
|
I made the suggested change in |
|
@DusanJovic-NOAA do you have the new MAPL/ESMF installed on hera? |
I don't. I already asked EPIC twice to install the updated version of MPAS. |
|
@bbakernoaa I repeated the I also updated SU2G_instance_SU.rc to include these two lines: My run directory on Hercules is /work2/noaa/stmp/djovic/stmp/djovic/FV3_RT/rt_4012304/cpld_control_p8_intel |
|
@weiyuan-jiang Can you access Hercules? May I ask if you can take a look as well? |
Yes, I will take a look |
This crash is not related to the volcanic emissions files. So changing the volcanic emissions files cannot cause this. Either something else was changed or changing the volcanic emissions files just meant the model got further and you hit a different problem. That said, the grid that is getting passed down to gocart and the cap to gocart, does that have a mask set on it somewhere else in UFS? |
|
@DusanJovic-NOAA may I ask where your model source code is for the run /work2/noaa/stmp/djovic/stmp/djovic/FV3_RT/rt_4012304/cpld_control_p8_intel? |
/work/noaa/fv3-cam/djovic/ufs/gocart_mapl/ufs-weather-model |
|
From @bena-nasa: I have made branch: https://github.com/GEOS-ESM/MAPL/tree/hotfix/bmauer/candidate_v2.46.4 with what should fix the issue you were seeing with MAPLv2.46.3, please try and let me know. If it fixes your issues we can make a v2.46.4 release of mapl and hotfix this onto our develop. @RatkoVasic-NOAA would you please install this MAPL version on Hercules for us to test if it resolves the model failure? Thanks |
|
From @bena-nasa: I have made branch: https://github.com/GEOS-ESM/MAPL/tree/hotfix/bmauer/candidate_v2.46.4 with what should fix the issue you were seeing with MAPLv2.46.3, please try and let me know. If it fixes your issues we can make a v2.46.4 release of mapl and hotfix this onto our develop. @RatkoVasic-NOAA would you please install this MAPL version on Hercules for us to test if it resolves the model failure? Thank What is the git syntax to get this new hotfix and build the new(er) MAPL? I am going to try to do this offline rather than waiting for possible down the road installation. |
|
@RatkoVasic-NOAA @jkbk2004 @ulmononian May I ask if the EPIC library team can install the MAPL candidate_v2.46.4 in spack-stack 1.6.0? We can't move on with the testing without the new library. Thanks |
|
How do I build this library offline? Git shell instructions especially
needed.
…On Tue, Oct 1, 2024 at 7:22 PM Jun Wang ***@***.***> wrote:
@RatkoVasic-NOAA <https://github.com/RatkoVasic-NOAA> @jkbk2004
<https://github.com/jkbk2004> @ulmononian <https://github.com/ulmononian>
May I ask if the EPIC library team can install the MAPL candidate_v2.46.4
<https://github.com/GEOS-ESM/MAPL/tree/hotfix/bmauer/candidate_v2.46.4>
in spack-stack 1.6.0?
We can't move on with the testing without the new library. Thanks
—
Reply to this email directly, view it on GitHub
<#2406 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDS4FXNNPNIQ3Q6RNFD3Q3ZZLZANAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBWG44DCMZSGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
George W Vandenberghe
*Lynker Technologies at * NOAA/NWS/NCEP/EMC
5830 University Research Ct., Rm. 2141
College Park, MD 20740
***@***.***
301-683-3769(work) 3017751547(cell)
|
|
@junwang-noaa @GeorgeVandenberghe-NOAA I can try to install that version. Which machine do you want to test? |
|
@RatkoVasic-NOAA can you install it on Hercules? Thanks |
@junwang-noaa will do. |
|
For me, hercules. Also how do I build that version offline myself. Having
trouble with the git to get that version.
…On Tue, Oct 1, 2024 at 8:07 PM RatkoVasic-NOAA ***@***.***> wrote:
@junwang-noaa <https://github.com/junwang-noaa> @GeorgeVandenberghe-NOAA
<https://github.com/GeorgeVandenberghe-NOAA> I can try to install that
version. Which machine do you want to test?
—
Reply to this email directly, view it on GitHub
<#2406 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDS4FWCTJI3LWIGDGGQLVDZZL6GTAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBWHE3DGNJSGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
George W Vandenberghe
*Lynker Technologies at * NOAA/NWS/NCEP/EMC
5830 University Research Ct., Rm. 2141
College Park, MD 20740
***@***.***
301-683-3769(work) 3017751547(cell)
|
|
@GeorgeVandenberghe-NOAA I have never installed MAPL outside of spack-stack. @bena-nasa can you please make a tag from your branch, I cannot install it in spack-stack. Here are available tags: |
|
I think I need this tag to for a shell git followed by build. I have the
build but haven't figured out how to get the source
…On Wed, Oct 2, 2024 at 3:49 PM RatkoVasic-NOAA ***@***.***> wrote:
@GeorgeVandenberghe-NOAA <https://github.com/GeorgeVandenberghe-NOAA> I
have never installed MAPL outside of spack-stack.
@bena-nasa <https://github.com/bena-nasa> can you please make a tag from
your branch, I cannot install it in spack-stack. Here are available tags:
version("2.48.0", sha256="60a0fc4fd82b1a05050666ae478da7d79d86305aff1643a57bc09cb5347323b7")
version("2.47.2", sha256="d4ca384bf249b755454cd486a26bae76944a7cae3a706b9a7c9298825077cac0")
version("2.47.1", sha256="ca3e94c0caa78a91591fe63603d1836196f5294d4baad7cf1d83b229b3a85916")
version("2.47.0", sha256="66c862d2ab8bcd6969e9728091dbca54f1f420e97e41424c4ba93ef606088459")
version("2.46.3", sha256="333e1382ab744302d28b6f39e7f5504c7919d77d2443d70af952f60cbd8f27e7")
version("2.46.2", sha256="6d397ad73042355967de8ef5b521d6135c004f96e93ae7b215f9ee325e75c6f0")
version("2.46.1", sha256="f3090281de6293b484259d58f852c45b98759de8291d36a4950e6d348ece6573")
version("2.46.0", sha256="726d9588b724bd43e5085d1a2f8d806d548f185ed6b22a1b13c0ed06212d7be2")
—
Reply to this email directly, view it on GitHub
<#2406 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDS4FTDC6IPFORIDHYB7V3ZZQIXDAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBZGAZDAMJTGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
George W Vandenberghe
*Lynker Technologies at * NOAA/NWS/NCEP/EMC
5830 University Research Ct., Rm. 2141
College Park, MD 20740
***@***.***
301-683-3769(work) 3017751547(cell)
|
|
I need the git syntax to properly get this hotfix
https://github.com/GEOS-ESM/MAPL/tree/hotfix/bmauer/candidate_v2.46.4
…On Wed, Oct 2, 2024 at 3:49 PM RatkoVasic-NOAA ***@***.***> wrote:
@GeorgeVandenberghe-NOAA <https://github.com/GeorgeVandenberghe-NOAA> I
have never installed MAPL outside of spack-stack.
@bena-nasa <https://github.com/bena-nasa> can you please make a tag from
your branch, I cannot install it in spack-stack. Here are available tags:
version("2.48.0", sha256="60a0fc4fd82b1a05050666ae478da7d79d86305aff1643a57bc09cb5347323b7")
version("2.47.2", sha256="d4ca384bf249b755454cd486a26bae76944a7cae3a706b9a7c9298825077cac0")
version("2.47.1", sha256="ca3e94c0caa78a91591fe63603d1836196f5294d4baad7cf1d83b229b3a85916")
version("2.47.0", sha256="66c862d2ab8bcd6969e9728091dbca54f1f420e97e41424c4ba93ef606088459")
version("2.46.3", sha256="333e1382ab744302d28b6f39e7f5504c7919d77d2443d70af952f60cbd8f27e7")
version("2.46.2", sha256="6d397ad73042355967de8ef5b521d6135c004f96e93ae7b215f9ee325e75c6f0")
version("2.46.1", sha256="f3090281de6293b484259d58f852c45b98759de8291d36a4950e6d348ece6573")
version("2.46.0", sha256="726d9588b724bd43e5085d1a2f8d806d548f185ed6b22a1b13c0ed06212d7be2")
—
Reply to this email directly, view it on GitHub
<#2406 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDS4FTDC6IPFORIDHYB7V3ZZQIXDAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBZGAZDAMJTGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
George W Vandenberghe
*Lynker Technologies at * NOAA/NWS/NCEP/EMC
5830 University Research Ct., Rm. 2141
College Park, MD 20740
***@***.***
301-683-3769(work) 3017751547(cell)
|
I believe: (might be |
|
I typo'd, it's GEOS-ESM |
|
Dies not finding repository
46.3]$ cd MAPL
***@***.*** MAPL]$ git remote add GOES-ESM
https://github.com/GOES-ESM/MAPL
***@***.*** MAPL]$ git remote update
Fetching origin
Fetching GOES-ESM
Username for 'https://github.com': ... upon supplying this it fails to
find the repository
On Wed, Oct 2, 2024 at 4:59 PM Brian Curtis ***@***.***>
wrote:
… I need the git syntax to properly get this hotfix
https://github.com/GEOS-ESM/MAPL/tree/hotfix/bmauer/candidate_v2.46.4
… <#m_-4507551138992535341_>
On Wed, Oct 2, 2024 at 3:49 PM RatkoVasic-NOAA *@*.*> wrote:
@GeorgeVandenberghe-NOAA <https://github.com/GeorgeVandenberghe-NOAA>
https://github.com/GeorgeVandenberghe-NOAA
<https://github.com/GeorgeVandenberghe-NOAA> I have never installed MAPL
outside of spack-stack. @bena-nasa <https://github.com/bena-nasa>
https://github.com/bena-nasa <https://github.com/bena-nasa> can you please
make a tag from your branch, I cannot install it in spack-stack. Here are
available tags: version("2.48.0",
sha256="60a0fc4fd82b1a05050666ae478da7d79d86305aff1643a57bc09cb5347323b7")
version("2.47.2",
sha256="d4ca384bf249b755454cd486a26bae76944a7cae3a706b9a7c9298825077cac0")
version("2.47.1",
sha256="ca3e94c0caa78a91591fe63603d1836196f5294d4baad7cf1d83b229b3a85916")
version("2.47.0",
sha256="66c862d2ab8bcd6969e9728091dbca54f1f420e97e41424c4ba93ef606088459")
version("2.46.3",
sha256="333e1382ab744302d28b6f39e7f5504c7919d77d2443d70af952f60cbd8f27e7")
version("2.46.2",
sha256="6d397ad73042355967de8ef5b521d6135c004f96e93ae7b215f9ee325e75c6f0")
version("2.46.1",
sha256="f3090281de6293b484259d58f852c45b98759de8291d36a4950e6d348ece6573")
version("2.46.0",
sha256="726d9588b724bd43e5085d1a2f8d806d548f185ed6b22a1b13c0ed06212d7be2")
— Reply to this email directly, view it on GitHub <#2406 (comment)
<#2406 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANDS4FTDC6IPFORIDHYB7V3ZZQIXDAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBZGAZDAMJTGY
<https://github.com/notifications/unsubscribe-auth/ANDS4FTDC6IPFORIDHYB7V3ZZQIXDAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBZGAZDAMJTGY>
. You are receiving this because you were mentioned.Message ID: @.*>
-- George W Vandenberghe *Lynker Technologies at * NOAA/NWS/NCEP/EMC 5830
University Research Ct., Rm. 2141 College Park, MD 20740 @.***
301-683-3769(work) 3017751547(cell)
I believe:
git remote add GOES-ESM https://github.com/GOES-ESM/MAPL
git remote update
git merge GOES-ESM hotfix/bmauer/candidate_v2.46.4
(might be git merge GOES-ESM/hotfix/bmauer/candidate_v2.46.4
—
Reply to this email directly, view it on GitHub
<#2406 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDS4FVEG44S6NRDXZ6AZB3ZZQQ5PAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBZGE3DINZTHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
George W Vandenberghe
*Lynker Technologies at * NOAA/NWS/NCEP/EMC
5830 University Research Ct., Rm. 2141
College Park, MD 20740
***@***.***
301-683-3769(work) 3017751547(cell)
|
|
I tried building MAPL-2.50.2 with my udunits library
/apps/spack-managed/gcc-11.3.1/intel-oneapi-compilers-2022.2.1-z2sjni66fcyqcsamnoccgb7c77mn37qj/compiler/2022.2.1/linux/bin/intel64/ifort
-fPIC -O3 -g -qopt-report0 -ftz -align all -fno-alias -traceback -assume
realloc_lhs -fpe0 -fp-model source -heap-arrays 32 -assume noold_maxminloc
-fimf-arch-consistency=true -align dcommons -Wl,--disable-new-dtags
-shared -nofor-main -Wl,-soname,libudunits2f.so -o ../lib/libudunits2f.so
CMakeFiles/udunits2f.dir/CptrWrapper.F90.o
CMakeFiles/udunits2f.dir/UDSystem.F90.o
CMakeFiles/udunits2f.dir/udunits2f.F90.o
CMakeFiles/udunits2f.dir/encoding.F90.o
CMakeFiles/udunits2f.dir/interfaces.F90.o
CMakeFiles/udunits2f.dir/status_codes.F90.o
CMakeFiles/udunits2f.dir/ut_set_ignore_error_message_handler.c.o
-Wl,-rpath,"\$ORIGIN/../lib64" /usr/lib64/libexpat.so
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a
-ldl -lirng -ldecimal -lcilkrts -lstdc++
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(unitcore.o):
relocation R_X86_64_32S against `productOps' can not be used when making a
shared object; recompile with -fPIC
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(converter.o):
relocation R_X86_64_32 against `trivialConverter' can not be used when
making a shared object; recompile with -fPIC
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(formatter.o):
relocation R_X86_64_32 against `.rodata.str1.4' can not be used when making
a shared object; recompile with -fPIC
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(unitToIdMap.o):
relocation R_X86_64_32 against `.text' can not be used when making a shared
object; recompile with -fPIC
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(unitAndId.o):
relocation R_X86_64_32 against `.rodata.str1.4' can not be used when making
a shared object; recompile with -fPIC
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(systemMap.o):
relocation R_X86_64_32 against `.text' can not be used when making a shared
object; recompile with -fPIC
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(parser.o):
relocation R_X86_64_32 against `.rodata.str1.4' can not be used when making
a shared object; recompile with -fPIC
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(xml.o):
relocation R_X86_64_32 against `buf.797.0.1' can not be used when making a
shared object; recompile with -fPIC
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(idToUnitMap.o):
relocation R_X86_64_32 against `.rodata.str1.4' can not be used when making
a shared object; recompile with -fPIC
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(prefix.o):
relocation R_X86_64_32 against `.rodata.str1.4' can not be used when making
a shared object; recompile with -fPIC
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(status.o):
warning: relocation in read-only section `.eh_frame'
make[2]: *** [udunits2f/CMakeFiles/udunits2f.dir/build.make:190:
lib/libudunits2f.so] Error 1
make[2]: Leaving directory
'/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/build/MAPL-2.50.2/build'
make[1]: *** [CMakeFiles/Makefile2:1572:
udunits2f/CMakeFiles/udunits2f.dir/all] Error 2
make[1]: Leaving directory
'/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/build/MAPL-2.50.2/build'
It does work if I use the system's udunits. What do I need to do to get
rid of this in my udunits . I make MAPL with
-DCMAKE_INSTALL_PREFIX=$NETP/MAPL-2.50.2 -DUSE_F2PY=OFF
-DCMAKE_Fortran_COMPILER=$FC \
…-DCMAKE_MODULE_PATH="${ESMA_CMAKE_ROOT};${CMAKEMODULES_ROOT}/Modules;${ECBUILD_ROOT}/share/ecbuild/cmake"
\
-DCMAKE_BUILD_TYPE=Release \
-DBUILD_WITH_FLAP=OFF \
-DBUILD_WITH_PFLOGGER=OFF \
-DBUILD_WITH_FARGPARSE=OFF \
-DESMA_USE_GFE_NAMESPACE=ON \
*-DBUILD_SHARED_MAPL=OFF \*
-DUSE_EXTDATA2G=OFF \
${CMAKE_OPTS}
On Wed, Nov 13, 2024 at 7:49 PM Matt Thompson ***@***.***> wrote:
MAPL v2.46.4 will not work with ESMF 8.6.1. At least , this block need to
be changed. here
<https://github.com/GEOS-ESM/MAPL/blob/3295ceebe7e870aaca2018c12ea1ac82d0628fa5/gridcomps/Cap/MAPL_CapGridComp.F90#L1081-L1091>
Indeed, but @bena-nasa <https://github.com/bena-nasa> did fix this bit up
in, I think, v2.50.2:
GEOS-ESM/MAPL#2994 <GEOS-ESM/MAPL#2994>
and you can see the current code here:
https://github.com/GEOS-ESM/MAPL/blob/306ca39603f28c238ff4991c9d9f2d36cf0fb8c0/gridcomps/Cap/MAPL_CapGridComp.F90#L980-L990
—
Reply to this email directly, view it on GitHub
<#2406 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDS4FT7PBKY5LYKJTZVZW32AOUNTAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZUGYYTMNZTGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
George W Vandenberghe
*Lynker Technologies at * NOAA/NWS/NCEP/EMC
5830 University Research Ct., Rm. 2141
College Park, MD 20740
***@***.***
301-683-3769(work) 3017751547(cell)
|
|
I got rid of it by building a shared udunits library upstream but why do I
need a shared library if I am making MAPL static only??
On Wed, Nov 13, 2024 at 8:44 PM George Vandenberghe - NOAA Affiliate <
***@***.***> wrote:
… I tried building MAPL-2.50.2 with my udunits library
/apps/spack-managed/gcc-11.3.1/intel-oneapi-compilers-2022.2.1-z2sjni66fcyqcsamnoccgb7c77mn37qj/compiler/2022.2.1/linux/bin/intel64/ifort
-fPIC -O3 -g -qopt-report0 -ftz -align all -fno-alias -traceback -assume
realloc_lhs -fpe0 -fp-model source -heap-arrays 32 -assume noold_maxminloc
-fimf-arch-consistency=true -align dcommons -Wl,--disable-new-dtags
-shared -nofor-main -Wl,-soname,libudunits2f.so -o ../lib/libudunits2f.so
CMakeFiles/udunits2f.dir/CptrWrapper.F90.o
CMakeFiles/udunits2f.dir/UDSystem.F90.o
CMakeFiles/udunits2f.dir/udunits2f.F90.o
CMakeFiles/udunits2f.dir/encoding.F90.o
CMakeFiles/udunits2f.dir/interfaces.F90.o
CMakeFiles/udunits2f.dir/status_codes.F90.o
CMakeFiles/udunits2f.dir/ut_set_ignore_error_message_handler.c.o
-Wl,-rpath,"\$ORIGIN/../lib64" /usr/lib64/libexpat.so
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a
-ldl -lirng -ldecimal -lcilkrts -lstdc++
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(unitcore.o):
relocation R_X86_64_32S against `productOps' can not be used when making a
shared object; recompile with -fPIC
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(converter.o):
relocation R_X86_64_32 against `trivialConverter' can not be used when
making a shared object; recompile with -fPIC
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(formatter.o):
relocation R_X86_64_32 against `.rodata.str1.4' can not be used when making
a shared object; recompile with -fPIC
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(unitToIdMap.o):
relocation R_X86_64_32 against `.text' can not be used when making a shared
object; recompile with -fPIC
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(unitAndId.o):
relocation R_X86_64_32 against `.rodata.str1.4' can not be used when making
a shared object; recompile with -fPIC
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(systemMap.o):
relocation R_X86_64_32 against `.text' can not be used when making a shared
object; recompile with -fPIC
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(parser.o):
relocation R_X86_64_32 against `.rodata.str1.4' can not be used when making
a shared object; recompile with -fPIC
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(xml.o):
relocation R_X86_64_32 against `buf.797.0.1' can not be used when making a
shared object; recompile with -fPIC
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(idToUnitMap.o):
relocation R_X86_64_32 against `.rodata.str1.4' can not be used when making
a shared object; recompile with -fPIC
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(prefix.o):
relocation R_X86_64_32 against `.rodata.str1.4' can not be used when making
a shared object; recompile with -fPIC
ld:
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(status.o):
warning: relocation in read-only section `.eh_frame'
make[2]: *** [udunits2f/CMakeFiles/udunits2f.dir/build.make:190:
lib/libudunits2f.so] Error 1
make[2]: Leaving directory
'/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/build/MAPL-2.50.2/build'
make[1]: *** [CMakeFiles/Makefile2:1572:
udunits2f/CMakeFiles/udunits2f.dir/all] Error 2
make[1]: Leaving directory
'/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/build/MAPL-2.50.2/build'
It does work if I use the system's udunits. What do I need to do to get
rid of this in my udunits . I make MAPL with
-DCMAKE_INSTALL_PREFIX=$NETP/MAPL-2.50.2 -DUSE_F2PY=OFF
-DCMAKE_Fortran_COMPILER=$FC \
-DCMAKE_MODULE_PATH="${ESMA_CMAKE_ROOT};${CMAKEMODULES_ROOT}/Modules;${ECBUILD_ROOT}/share/ecbuild/cmake"
\
-DCMAKE_BUILD_TYPE=Release \
-DBUILD_WITH_FLAP=OFF \
-DBUILD_WITH_PFLOGGER=OFF \
-DBUILD_WITH_FARGPARSE=OFF \
-DESMA_USE_GFE_NAMESPACE=ON \
*-DBUILD_SHARED_MAPL=OFF \*
-DUSE_EXTDATA2G=OFF \
${CMAKE_OPTS}
On Wed, Nov 13, 2024 at 7:49 PM Matt Thompson ***@***.***>
wrote:
> MAPL v2.46.4 will not work with ESMF 8.6.1. At least , this block need to
> be changed. here
> <https://github.com/GEOS-ESM/MAPL/blob/3295ceebe7e870aaca2018c12ea1ac82d0628fa5/gridcomps/Cap/MAPL_CapGridComp.F90#L1081-L1091>
>
> Indeed, but @bena-nasa <https://github.com/bena-nasa> did fix this bit
> up in, I think, v2.50.2:
>
> GEOS-ESM/MAPL#2994 <GEOS-ESM/MAPL#2994>
>
> and you can see the current code here:
>
>
> https://github.com/GEOS-ESM/MAPL/blob/306ca39603f28c238ff4991c9d9f2d36cf0fb8c0/gridcomps/Cap/MAPL_CapGridComp.F90#L980-L990
>
> —
> Reply to this email directly, view it on GitHub
> <#2406 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ANDS4FT7PBKY5LYKJTZVZW32AOUNTAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZUGYYTMNZTGU>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
George W Vandenberghe
*Lynker Technologies at * NOAA/NWS/NCEP/EMC
5830 University Research Ct., Rm. 2141
College Park, MD 20740
***@***.***
301-683-3769(work) 3017751547(cell)
--
George W Vandenberghe
*Lynker Technologies at * NOAA/NWS/NCEP/EMC
5830 University Research Ct., Rm. 2141
College Park, MD 20740
***@***.***
301-683-3769(work) 3017751547(cell)
|
|
For what it's worth a static MAPL-2.50.2 is available in
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/MAPL-2.50.2
I use it by prepending
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/MAPL-2.50.2
to CMAKE_PREFIX_PATH
I don't know if it's of any use but I tried.
On Wed, Nov 13, 2024 at 8:51 PM George Vandenberghe - NOAA Affiliate <
***@***.***> wrote:
… I got rid of it by building a shared udunits library upstream but why do I
need a shared library if I am making MAPL static only??
On Wed, Nov 13, 2024 at 8:44 PM George Vandenberghe - NOAA Affiliate <
***@***.***> wrote:
> I tried building MAPL-2.50.2 with my udunits library
> /apps/spack-managed/gcc-11.3.1/intel-oneapi-compilers-2022.2.1-z2sjni66fcyqcsamnoccgb7c77mn37qj/compiler/2022.2.1/linux/bin/intel64/ifort
> -fPIC -O3 -g -qopt-report0 -ftz -align all -fno-alias -traceback -assume
> realloc_lhs -fpe0 -fp-model source -heap-arrays 32 -assume noold_maxminloc
> -fimf-arch-consistency=true -align dcommons -Wl,--disable-new-dtags
> -shared -nofor-main -Wl,-soname,libudunits2f.so -o ../lib/libudunits2f.so
> CMakeFiles/udunits2f.dir/CptrWrapper.F90.o
> CMakeFiles/udunits2f.dir/UDSystem.F90.o
> CMakeFiles/udunits2f.dir/udunits2f.F90.o
> CMakeFiles/udunits2f.dir/encoding.F90.o
> CMakeFiles/udunits2f.dir/interfaces.F90.o
> CMakeFiles/udunits2f.dir/status_codes.F90.o
> CMakeFiles/udunits2f.dir/ut_set_ignore_error_message_handler.c.o
> -Wl,-rpath,"\$ORIGIN/../lib64" /usr/lib64/libexpat.so
> /work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a
> -ldl -lirng -ldecimal -lcilkrts -lstdc++
> ld:
> /work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(unitcore.o):
> relocation R_X86_64_32S against `productOps' can not be used when making a
> shared object; recompile with -fPIC
> ld:
> /work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(converter.o):
> relocation R_X86_64_32 against `trivialConverter' can not be used when
> making a shared object; recompile with -fPIC
> ld:
> /work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(formatter.o):
> relocation R_X86_64_32 against `.rodata.str1.4' can not be used when making
> a shared object; recompile with -fPIC
> ld:
> /work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(unitToIdMap.o):
> relocation R_X86_64_32 against `.text' can not be used when making a shared
> object; recompile with -fPIC
> ld:
> /work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(unitAndId.o):
> relocation R_X86_64_32 against `.rodata.str1.4' can not be used when making
> a shared object; recompile with -fPIC
> ld:
> /work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(systemMap.o):
> relocation R_X86_64_32 against `.text' can not be used when making a shared
> object; recompile with -fPIC
> ld:
> /work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(parser.o):
> relocation R_X86_64_32 against `.rodata.str1.4' can not be used when making
> a shared object; recompile with -fPIC
> ld:
> /work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(xml.o):
> relocation R_X86_64_32 against `buf.797.0.1' can not be used when making a
> shared object; recompile with -fPIC
> ld:
> /work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(idToUnitMap.o):
> relocation R_X86_64_32 against `.rodata.str1.4' can not be used when making
> a shared object; recompile with -fPIC
> ld:
> /work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(prefix.o):
> relocation R_X86_64_32 against `.rodata.str1.4' can not be used when making
> a shared object; recompile with -fPIC
> ld:
> /work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/lib/libudunits2.a(status.o):
> warning: relocation in read-only section `.eh_frame'
> make[2]: *** [udunits2f/CMakeFiles/udunits2f.dir/build.make:190:
> lib/libudunits2f.so] Error 1
> make[2]: Leaving directory
> '/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/build/MAPL-2.50.2/build'
> make[1]: *** [CMakeFiles/Makefile2:1572:
> udunits2f/CMakeFiles/udunits2f.dir/all] Error 2
> make[1]: Leaving directory
> '/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/build/MAPL-2.50.2/build'
>
>
> It does work if I use the system's udunits. What do I need to do to get
> rid of this in my udunits . I make MAPL with
>
> -DCMAKE_INSTALL_PREFIX=$NETP/MAPL-2.50.2 -DUSE_F2PY=OFF
> -DCMAKE_Fortran_COMPILER=$FC \
>
> -DCMAKE_MODULE_PATH="${ESMA_CMAKE_ROOT};${CMAKEMODULES_ROOT}/Modules;${ECBUILD_ROOT}/share/ecbuild/cmake"
> \
> -DCMAKE_BUILD_TYPE=Release \
> -DBUILD_WITH_FLAP=OFF \
> -DBUILD_WITH_PFLOGGER=OFF \
> -DBUILD_WITH_FARGPARSE=OFF \
> -DESMA_USE_GFE_NAMESPACE=ON \
> *-DBUILD_SHARED_MAPL=OFF \*
> -DUSE_EXTDATA2G=OFF \
> ${CMAKE_OPTS}
>
>
>
>
> On Wed, Nov 13, 2024 at 7:49 PM Matt Thompson ***@***.***>
> wrote:
>
>> MAPL v2.46.4 will not work with ESMF 8.6.1. At least , this block need
>> to be changed. here
>> <https://github.com/GEOS-ESM/MAPL/blob/3295ceebe7e870aaca2018c12ea1ac82d0628fa5/gridcomps/Cap/MAPL_CapGridComp.F90#L1081-L1091>
>>
>> Indeed, but @bena-nasa <https://github.com/bena-nasa> did fix this bit
>> up in, I think, v2.50.2:
>>
>> GEOS-ESM/MAPL#2994 <GEOS-ESM/MAPL#2994>
>>
>> and you can see the current code here:
>>
>>
>> https://github.com/GEOS-ESM/MAPL/blob/306ca39603f28c238ff4991c9d9f2d36cf0fb8c0/gridcomps/Cap/MAPL_CapGridComp.F90#L980-L990
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#2406 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/ANDS4FT7PBKY5LYKJTZVZW32AOUNTAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZUGYYTMNZTGU>
>> .
>> You are receiving this because you were mentioned.Message ID:
>> ***@***.***>
>>
>
>
> --
>
> George W Vandenberghe
>
> *Lynker Technologies at * NOAA/NWS/NCEP/EMC
>
> 5830 University Research Ct., Rm. 2141
>
> College Park, MD 20740
>
> ***@***.***
>
>
> 301-683-3769(work) 3017751547(cell)
>
>
--
George W Vandenberghe
*Lynker Technologies at * NOAA/NWS/NCEP/EMC
5830 University Research Ct., Rm. 2141
College Park, MD 20740
***@***.***
301-683-3769(work) 3017751547(cell)
--
George W Vandenberghe
*Lynker Technologies at * NOAA/NWS/NCEP/EMC
5830 University Research Ct., Rm. 2141
College Park, MD 20740
***@***.***
301-683-3769(work) 3017751547(cell)
|
|
@GeorgeVandenberghe-NOAA As far as I can tell from our Indeed, in Baselibs, we build udunits2 as static, but we can also build MAPL with spack and as far as I can see from the spack package, that is built as shared by default. So, I can only conclude, MAPL does not care what type of udunits is built. |
|
I built a static only udunits and MAPL failed to build with the previously
mentioned errors. When I rebuilt udunits to build a shared library as well
MAPL-2.50.2 did build. I want to try to build as much as possible without
shared libraries because they require a properly configured runtime
environment whereas a static executable just works if it built . I
realize I am slowly losing that battle.
…On Wed, Nov 13, 2024 at 6:29 PM Matt Thompson ***@***.***> wrote:
@GeorgeVandenberghe-NOAA <https://github.com/GeorgeVandenberghe-NOAA> As
far as I can tell from our Findudunits.cmake file
<https://github.com/GEOS-ESM/MAPL/blob/main/cmake/Findudunits.cmake>, it
shouldn't care if it's shared or not.
Indeed, in Baselibs, we build udunits2 as static
<https://github.com/GEOS-ESM/ESMA-Baselibs/blob/0455906a62fb9562bb90207abf4d743b2f0b88ea/GNUmakefile#L691-L701>,
but we can also build MAPL with spack and as far as I can see from the
spack package, that is built as shared by default
<https://github.com/spack/spack/blob/1cea82b6299506519fff684a3bd0cf82eb6c8182/var/spack/repos/builtin/packages/udunits/package.py#L43>
.
So, I can only conclude, MAPL does not care what type of udunits is built.
—
Reply to this email directly, view it on GitHub
<#2406 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDS4FTL5BB4EGOPKLI4E2L2APOGHAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZVGAZTENRWGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
George W Vandenberghe
*Lynker Technologies at * NOAA/NWS/NCEP/EMC
5830 University Research Ct., Rm. 2141
College Park, MD 20740
***@***.***
301-683-3769(work) 3017751547(cell)
|
|
$ ls -l /work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/MAPL-2.50.2 |
|
Is MAPL v2.50.2 expected to fix the GOCART errors we had with v2.46.x? |
@DusanJovic-NOAA I would...hope so? All I can say is that MAPL v2.50.2 is a superset of the v2.40.3.1. Every change we backported to v2.40.3.1 is in v2.50.2. Obviously there is a lot more in v2.50, but it should have everything that was added in the tweak version. |
|
I fixed the permissions.
…On Thu, Nov 14, 2024 at 12:41 PM Dusan Jovic ***@***.***> wrote:
$ ls -l
/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/MAPL-2.50.2
ls: cannot access
'/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/MAPL-2.50.2':
Permission denied
—
Reply to this email directly, view it on GitHub
<#2406 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDS4FR4XD3UAZIMW4OC57T2ASK65AVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZWGI2TOMRZGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
George W Vandenberghe
*Lynker Technologies at * NOAA/NWS/NCEP/EMC
5830 University Research Ct., Rm. 2141
College Park, MD 20740
***@***.***
301-683-3769(work) 3017751547(cell)
|
|
I get this error with 2.50.2 that George compiled code changes for this test: diff --git a/CMakeLists.txt b/CMakeLists.txt
index 702cf6a4..eaa9166b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -152,6 +152,7 @@ endif()
find_package(NetCDF 4.7.4 REQUIRED C Fortran)
find_package(ESMF 8.3.0 MODULE REQUIRED)
+add_library(ESMF::ESMF ALIAS esmf)
if(FMS)
find_package(FMS 2022.04 REQUIRED COMPONENTS R4 R8)
if(APP MATCHES "^(HAFSW)$")
diff --git a/modulefiles/ufs_common.lua b/modulefiles/ufs_common.lua
index 062fa384..f35d0d2e 100644
--- a/modulefiles/ufs_common.lua
+++ b/modulefiles/ufs_common.lua
@@ -10,7 +10,7 @@ local ufs_modules = {
{["netcdf-c"] = "4.9.2"},
{["netcdf-fortran"] = "4.6.1"},
{["parallelio"] = "2.5.10"},
- {["esmf"] = "8.6.0"},
+ {["esmf"] = "8.6.1"},
{["fms"] = "2024.01"},
{["bacio"] = "2.4.1"},
{["crtm"] = "2.4.0"},
@@ -20,7 +20,7 @@ local ufs_modules = {
{["sp"] = "2.5.0"},
{["w3emc"] = "2.10.0"},
{["gftl-shared"] = "1.6.1"},
- {["mapl"] = "2.40.3-esmf-8.6.0"},
+ -- {["mapl"] = "2.40.3.1-esmf-8.6.1"},
{["scotch"] = "7.0.4"},
}
diff --git a/modulefiles/ufs_hercules.intel.lua b/modulefiles/ufs_hercules.intel.lua
index 455ea4d0..3abb247c 100644
--- a/modulefiles/ufs_hercules.intel.lua
+++ b/modulefiles/ufs_hercules.intel.lua
@@ -2,7 +2,7 @@ help([[
loads UFS Model prerequisites for Hercules/Intel
]])
-prepend_path("MODULEPATH", "/work/noaa/epic/role-epic/spack-stack/hercules/spack-stack-1.6.0/envs/fms-2024.01/install/modulefiles/Core")
+prepend_path("MODULEPATH", "/work/noaa/epic/role-epic/spack-stack/hercules/spack-stack-1.6.0/envs/mapl-2.40.3.1-intel-2021.9.0/install/modulefiles/Core")
stack_intel_ver=os.getenv("stack_intel_ver") or "2021.9.0"
load(pathJoin("stack-intel", stack_intel_ver))
@@ -13,6 +13,8 @@ load(pathJoin("stack-intel-oneapi-mpi", stack_impi_ver))
cmake_ver=os.getenv("cmake_ver") or "3.23.1"
load(pathJoin("cmake", cmake_ver))
+prepend_path("CMAKE_PREFIX_PATH", "/work/noaa/noaatest/gwv/herc/simstacks/simstack.1008/netcdf140.492.460.mapl241.fms2301.crtm240/MAPL-2.50.2")
+
load("ufs_common")
nccmp_ver=os.getenv("nccmp_ver") or "1.9.0.1" |
|
@DusanJovic-NOAA Can you point us to the HISTORY.rc being used? I found: https://github.com/ufs-community/ufs-weather-model/blob/develop/tests/parm/gocart/AERO_HISTORY.rc.IN but that looks boring and should definitely be fine. |
$ ls -l /work2/noaa/stmp/djovic/stmp/djovic/FV3_RT/rt_1214371/cpld_control_p8_intel/AERO_HISTORY.rc |
|
I rebuilt mapl v2.50.2 and reran cpld_control_p8 test and I now see errors similar to what we had before: In stdout I also see: I'm not sure if these messages in stdout are new or not, I do not remember if I looked at stdout before, maybe just at stderr. Anyway, my run directory is: /work2/noaa/stmp/djovic/stmp/djovic/FV3_RT/rt_1287125/cpld_control_p8_intel |
|
I believe v2.50.2 and v2.46.4 have the same issue here |
|
Ugh. ETA: But yes, as @weiyuan-jiang says, I think that is same weird "getting to the wrong bit of MAPL" we were seeing. ETA2: We think we know the fix for the "infinite SU" but I'll want to test it. I mean, it's not what is breaking things (just a print) but it is annoying. |
|
I added a debug print in Base_Base_implementation.F90 right before code prints FAIL message, like this: and I see in stderr file: Shouldn't |
|
Hmm. I think that sort of looks like the weirdness @weiyuan-jiang has been seeing, but he or @tclune can comment more. (Like our VM or something is corrupted?) Do you see the same issue with GCC? We were "hoping" that if GCC shows the same issue, it might be something MAPL-ESMF related. But maybe this is an Intel 2021.9 issue? (We've never run with that version.) |
|
I think it is similar. We basically found that the VM gets confused and starts thinking it is running on a single PET. We compute IM_WORLD by summing over the DE's, and ... when there is only 1 PET, you end up seeing local extents where we expect to see global extents. Let me know if this does not align with the numbers you are seeing. |
|
Since MAPL 2.40.3 is working, could there be something introduced in a later version of MAPL causing the problem? |
|
I had noticed that when compiling failed, it still got an executable and the test still run. Something must be wrong here. For example, /work2/noaa/stmp/wjiang/stmp/wjiang/FV3_RT/rt_662081 |
It is probably using the executable from some of the previous runs that successfully compiled the code but failed the overall regression test, so the executables are not deleted. Make sure you delete all previously built executables. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
Description:
This PR requires two libraries (ESMF v8.6.1 and MAPL v 2.64.3) to be installed on all supported machines. So far, I'm testing these updates on Hercules using
ue-esmf-8.6.1-mapl-2.46.2spack-stack.Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: