Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropped vertically centered div, but when content overflows, it shoul... #73

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Dropped vertically centered div, but when content overflows, it shoul... #73

merged 5 commits into from
Sep 20, 2023

Conversation

jtm13
Copy link
Contributor

@jtm13 jtm13 commented Sep 13, 2023

…d be at the top

Description

The login and signup no longer center vertically. However, when they overflow, they appear right below the sticky header instead of halfway through.

Typically this will be a summary of your ticket.

What are you changing?

  • Shawn's change.

Did you increase testing or code coverage?

NO

Did you add any dependencies to the project?

NO

Did you update the relevant documentation?

NO, since it was just visual changes.

@jtm13
Copy link
Contributor Author

jtm13 commented Sep 13, 2023

Also added the right colors. Edited the tailwind.config.js file to make it to where we can use an alias (primary) for the main color for the site. I did it so that we can use the tailwind classes while not having to change multiple files multiple times for just a main color change again.

@jtm13 jtm13 linked an issue Sep 18, 2023 that may be closed by this pull request
mybyte: Change color scheme from purple to red #74
Open
@shawnpradeep
Copy link
Member

Can we have the content all fit within the viewport?

i.e.
image

image

@jtm13
Copy link
Contributor Author

jtm13 commented Sep 18, 2023

Do you want it to fit with all viewports? Like mobile and desktop? If so, would readability be a problem?

@shawnpradeep
Copy link
Member

for now, let's just stick to desktop. we can implement mobile down the line

@jtm13 jtm13 marked this pull request as ready for review September 20, 2023 00:45
@jtm13 jtm13 requested a review from genki-aik as a code owner September 20, 2023 00:45
@jtm13 jtm13 merged commit a2c10c5 into feature/newlandingpage Sep 20, 2023
4 checks passed
@dhruv2253 dhruv2253 deleted the feature/newlandingpage-jm branch September 20, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruv2253 dhruv2253 dhruv2253 approved these changes

@shawnpradeep shawnpradeep Awaiting requested review from shawnpradeep

@genki-aik genki-aik Awaiting requested review from genki-aik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mybyte: Change color scheme from purple to red
3 participants
@jtm13 @shawnpradeep @dhruv2253