-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/password reset #29
base: release
Are you sure you want to change the base?
Conversation
React hook form actually does not re-render the page every input so I don't think the error message renders for me. I will take a look and make it re-render every time. |
It might be better to use FirebaseErrors instead of matching string errors, I will update you on that as well |
If it does not work on your end, then I can find another way to make it work. |
I did think about doing that, but I choose the dirtier option since, in Typescript, you can only specify errors as any or unknown. Also, in JavaScript (and Typescript), there is only one catch as opposed to Java, where you can catch specific errors without much boilerplate. Since, when looking at the docs, there is no section in the method detail |
Actually now that I think about it, the error would still be surpressed anyway if we did just FirebaseErrors, so it would not be any difference except cleaner code. I'll do that sometime tomorrow. |
Made the state pass through the URL and call |
Handled the firebase error on issue #27