Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset building: replace laravel-mix with esbuild #144

Merged
merged 11 commits into from
May 30, 2024
Merged

Conversation

verheyenkoen
Copy link
Contributor

No description provided.

@verheyenkoen verheyenkoen self-assigned this May 28, 2024
@verheyenkoen verheyenkoen added the enhancement New feature or request label May 28, 2024
cli/server_cmd.go Outdated Show resolved Hide resolved
@verheyenkoen
Copy link
Contributor Author

verheyenkoen commented May 29, 2024

@mietcls Can you review the changed scss files from this PR plz? Does this include any files that you would overwrite when applying theme updates? Especially the fixes for the tagify styles were necessary. These are on old line numbers 549-550 and new line numbers 588-589. I couldn't find where this file originated from. This "bug" was never in the history from the tagify library, unless they purged it maybe.

Also currently there's one deprecation warning during build because a dependency from bootstrap uses the abs() function with a percentage. This has already been fixed in the latest bootstrap version so this would probably disappear on the next update.

@verheyenkoen verheyenkoen marked this pull request as ready for review May 29, 2024 14:37
@verheyenkoen
Copy link
Contributor Author

Some manual sass fixes need to be backported to the prototype repo.

@verheyenkoen
Copy link
Contributor Author

Also sent images through ImageOptim which reduced the buindle size with about 200Kb (20%).

reflex.conf.example Outdated Show resolved Hide resolved
cli/server_cmd.go Show resolved Hide resolved
@verheyenkoen verheyenkoen requested a review from nics May 30, 2024 11:09
@nics nics merged commit 2b7f3c7 into dev May 30, 2024
2 checks passed
@nics nics deleted the laravel-mix-to-esbuild branch May 30, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants