New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in comment in add_noise function for PointModel class? #25

Open

auroradh opened this issue Mar 29, 2023 · 1 comment

Assignees

auroradh commented Mar 29, 2023

Should noise_to_signal_ratio defined as "X_rms/S_rms" be squared in the comment in line 193 in point_model.py such that

"noise_to_signal_ratio: float, defined as (X_rms/S_rms)**2 where X is noise and S is signal." ?

At the moment, the documentation says that the input parameter noise_to_signal_ratio = sqrt(epsilon) if I understand it correctly.

engeir assigned gregordecristoforo

Member

engeir commented Jan 15, 2024

From @gregordecristoforo in 7b80808.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment