-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/tet 372 bump cypress to v12 #6425
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #50989 ↗︎
Details:
Review all test suite changes for PR #6425 ↗︎ |
oliverjwroberts
force-pushed
the
feature/TET-372-bump-cypress-to-v12
branch
2 times, most recently
from
January 23, 2024 09:13
08b544f
to
74329a7
Compare
3 tasks
Additional ticket for investigating Apple Silicon issues for Docker and Cypress: https://uktrade.atlassian.net/browse/TET-636 |
oliverjwroberts
force-pushed
the
feature/TET-372-bump-cypress-to-v12
branch
2 times, most recently
from
January 26, 2024 15:39
64c4652
to
83e78aa
Compare
DeanElliott96
force-pushed
the
feature/TET-372-bump-cypress-to-v12
branch
3 times, most recently
from
February 2, 2024 12:07
86359aa
to
a674f29
Compare
oliverjwroberts
force-pushed
the
feature/TET-372-bump-cypress-to-v12
branch
from
February 7, 2024 13:27
a674f29
to
c9bfe13
Compare
PippoRaimondiDIT
approved these changes
Feb 12, 2024
Co-authored-by: Dean Elliott <[email protected]>
Co-authored-by: Dean Elliott <[email protected]>
…d TODO need further review)
Co-authored-by: Oliver Roberts <[email protected]>
Co-authored-by: Oliver Roberts <[email protected]>
Co-authored-by: Oliver Roberts <[email protected]>
Co-authored-by: Oliver Roberts <[email protected]>
Co-authored-by: Oliver Roberts <[email protected]>
Co-authored-by: Dean Elliott <[email protected]>
… image and running the visual tests
…onent tests and run them locally
…dependencies image
DeanElliott96
force-pushed
the
feature/TET-372-bump-cypress-to-v12
branch
from
February 12, 2024 10:14
c9bfe13
to
d9f85bd
Compare
paulgain
approved these changes
Feb 12, 2024
chopkinsmade
pushed a commit
that referenced
this pull request
Feb 12, 2024
…ypress-to-v12 generated from commit 16e7415
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Upgrades cypress from v11 to v12. The main change with cypress v12 is that test isolation is enabled by default. This means that for each test the browser context is cleared and each test now needs to be independent and not rely on a previous tests.
Cypress would prefer bigger tests rather than smaller tests as you would need to visit a page for each smaller test instead of only once for a bigger test. I've linked best practices below.
See migration guide here: https://docs.cypress.io/guides/references/migration-guide#Migrating-to-Cypress-120
Best practices: https://docs.cypress.io/guides/references/best-practices
Test instructions
All cypress tests working they were previously.
Checklist