Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tet 372 bump cypress to v12 #6425

Merged
merged 35 commits into from
Feb 12, 2024

Conversation

DeanElliott96
Copy link
Contributor

@DeanElliott96 DeanElliott96 commented Jan 11, 2024

Description of change

Upgrades cypress from v11 to v12. The main change with cypress v12 is that test isolation is enabled by default. This means that for each test the browser context is cleared and each test now needs to be independent and not rely on a previous tests.

Cypress would prefer bigger tests rather than smaller tests as you would need to visit a page for each smaller test instead of only once for a bigger test. I've linked best practices below.

See migration guide here: https://docs.cypress.io/guides/references/migration-guide#Migrating-to-Cypress-120
Best practices: https://docs.cypress.io/guides/references/best-practices

Test instructions

All cypress tests working they were previously.

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

Copy link

cypress bot commented Jan 11, 2024

Passing run #50989 ↗︎

0 24 0 0 Flakiness 0

Details:

Update export wins for test isolation, disable test isolation for multi step for...
Project: data-hub-frontend Commit: d9f85bd714
Status: Passed Duration: 02:04 💡
Started: Feb 12, 2024 10:22 AM Ended: Feb 12, 2024 10:24 AM

Review all test suite changes for PR #6425 ↗︎

@oliverjwroberts oliverjwroberts force-pushed the feature/TET-372-bump-cypress-to-v12 branch 2 times, most recently from 08b544f to 74329a7 Compare January 23, 2024 09:13
@DeanElliott96 DeanElliott96 removed the WIP label Jan 26, 2024
@DeanElliott96
Copy link
Contributor Author

DeanElliott96 commented Jan 26, 2024

Additional ticket for investigating Apple Silicon issues for Docker and Cypress: https://uktrade.atlassian.net/browse/TET-636

@oliverjwroberts oliverjwroberts force-pushed the feature/TET-372-bump-cypress-to-v12 branch 2 times, most recently from 64c4652 to 83e78aa Compare January 26, 2024 15:39
@DeanElliott96 DeanElliott96 force-pushed the feature/TET-372-bump-cypress-to-v12 branch 3 times, most recently from 86359aa to a674f29 Compare February 2, 2024 12:07
@oliverjwroberts oliverjwroberts force-pushed the feature/TET-372-bump-cypress-to-v12 branch from a674f29 to c9bfe13 Compare February 7, 2024 13:27
DeanElliott96 and others added 23 commits February 12, 2024 10:14
@DeanElliott96 DeanElliott96 force-pushed the feature/TET-372-bump-cypress-to-v12 branch from c9bfe13 to d9f85bd Compare February 12, 2024 10:14
@DeanElliott96 DeanElliott96 merged commit 16e7415 into main Feb 12, 2024
16 checks passed
@DeanElliott96 DeanElliott96 deleted the feature/TET-372-bump-cypress-to-v12 branch February 12, 2024 11:14
chopkinsmade pushed a commit that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants