Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Export Win - Win details (step 4 of 6) #6455

Merged
merged 8 commits into from
Jan 25, 2024
Merged

Add Export Win - Win details (step 4 of 6) #6455

merged 8 commits into from
Jan 25, 2024

Conversation

paulgain
Copy link
Contributor

Description of change

This is step 4 of 6 of the Export Win user journey that enables Lead Officers to add an Export Win to Data Hub.

Test instructions

Go to /exportwins/create?step=win_details&company=<company-uuid>

  1. Enter values for all fields (there are lots)
  2. Click continue
  3. Click back
  4. Ensure all data entered from 1. has persisted.

Screenshots

Screenshot 2024-01-23 at 12 57 10

Validation

Screenshot 2024-01-23 at 12 59 12

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

@paulgain paulgain requested a review from a team as a code owner January 23, 2024 13:00
@paulgain paulgain changed the title Add Export Win - Customer details (4 of 6 steps) Add Export Win - Win details (4 of 6 steps) Jan 23, 2024
Copy link

cypress bot commented Jan 23, 2024

Passing run #50445 ↗︎

0 24 0 0 Flakiness 0

Details:

Add functional tests for total export value across all 3 win types
Project: data-hub-frontend Commit: 8aa4a4accf
Status: Passed Duration: 02:04 💡
Started: Jan 24, 2024 2:16 PM Ended: Jan 24, 2024 2:18 PM

Review all test suite changes for PR #6455 ↗︎

@paulgain paulgain changed the title Add Export Win - Win details (4 of 6 steps) Add Export Win - Win details (step 4 of 6) Jan 24, 2024
Copy link
Contributor

@cgsunkel cgsunkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a couple of typos

Copy link
Contributor

@dredmonds dredmonds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after typographical correction.

@paulgain
Copy link
Contributor Author

LGTM apart from a couple of typos

@cgsunkel thank you. Do you mind if I make the changes in the next PR which is coming straight up. I have two approvals and don't want to rerun everything again on typos (important as they are). Thanks.

@paulgain paulgain merged commit 46257e9 into main Jan 25, 2024
16 checks passed
@paulgain paulgain deleted the feat/win-details branch January 25, 2024 11:11
chopkinsmade pushed a commit that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants