Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Export Win - Check before sending (step 6 of 6) #6477

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

paulgain
Copy link
Contributor

@paulgain paulgain commented Jan 31, 2024

Description of change

This is step 6 of 6 of the Export Win user journey that enables Lead Officers to add an Export Win to Data Hub.

Test instructions

Go to /exportwins/create?step=officer_details&company=<company-uuid> and complete the entire user journey before submitting the form.

Screenshots

Screenshot 2024-02-01 at 13 02 40

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

@paulgain paulgain requested a review from a team as a code owner January 31, 2024 11:56
@paulgain paulgain force-pushed the feat/check-before-sending branch from 924a811 to 4ba4e4c Compare January 31, 2024 12:01
Copy link

cypress bot commented Jan 31, 2024

Passing run #50763 ↗︎

0 75 7 0 Flakiness 0

Details:

Fix functional tests
Project: data-hub-frontend Commit: 7d3c1afba3
Status: Passed Duration: 07:57 💡
Started: Feb 1, 2024 3:03 PM Ended: Feb 1, 2024 3:11 PM

Review all test suite changes for PR #6477 ↗︎

Copy link
Contributor

@dredmonds dredmonds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good the Export Win final steps summary.👍

@paulgain paulgain force-pushed the feat/check-before-sending branch 4 times, most recently from 70699c8 to 3847663 Compare February 1, 2024 11:31
@paulgain paulgain force-pushed the feat/check-before-sending branch from 3847663 to f44eb4f Compare February 1, 2024 11:41
@paulgain paulgain merged commit be6dc8a into main Feb 1, 2024
16 checks passed
@paulgain paulgain deleted the feat/check-before-sending branch February 1, 2024 15:57
chopkinsmade pushed a commit that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants