Fix labels for EYB leads with is_high_value=None on collection and details page
#7391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add unknown value
data-hub-frontend
|
||||||||||||||||||||||||||||
| Project |
data-hub-frontend
|
| Branch Review |
fix/CLS2-1083-Is-high-value-fix-and-addition
|
| Run status |
|
| Run duration | 01m 39s |
| Commit |
|
| Committer | Oliver Roberts |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
15
|
| View all changes introduced in this branch ↗︎ | |
oliverjwroberts
changed the title
is_high_value=None on collection and details page
santoshdasa12345
approved these changes
Dec 12, 2024
swenban
approved these changes
Dec 12, 2024
p3dr0migue1
approved these changes
Dec 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7391 +/- ##
==========================================
+ Coverage 87.99% 88.01% +0.01%
==========================================
Files 1168 1168
Lines 18171 18172 +1
Branches 5139 5140 +1
==========================================
+ Hits 15990 15994 +4
+ Misses 2181 2178 -3 ☔ View full report in Codecov by Sentry. |
oliverjwroberts
deleted the
fix/CLS2-1083-Is-high-value-fix-and-addition
branch
dredmonds
pushed a commit
that referenced
this pull request
Dec 13, 2024
…details page (#7391) * WIP: fix is high value on details page add unknown value * Test EYB leads with unknown values on collection and detail pages --------- Co-authored-by: Oliver Roberts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the EYB Leads lists and detail pages show the correct value for Value (Unknown, High value or Low value)
Description of change
An EYB Lead with
Is high valueset toUnknownis shown as eitherHigh valueorLow valuedepending on were. This should be displayed asUnknown valueTest instructions
Set the Is high value to High value, Low value and Unknown in Django admin this should be reflected correctly on the details and list pages.
Screenshots
Before
After
Checklist