-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for OMIS order activity #7397
Conversation
data-hub-frontend Run #58004
Run Properties:
|
Project |
data-hub-frontend
|
Branch Review |
chore/add-tests-for-omis-activity
|
Run status |
Passed #58004
|
Run duration | 01m 38s |
Commit |
44a0c9ce62: Remove legacy OMIS activity code and other dead AS code
|
Committer | Christopher |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
15
|
View all changes introduced in this branch ↗︎ |
2e6ac4b
to
44a0c9c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7397 +/- ##
==========================================
+ Coverage 87.98% 88.47% +0.49%
==========================================
Files 1167 1159 -8
Lines 18140 18053 -87
Branches 5137 5125 -12
==========================================
+ Hits 15961 15973 +12
+ Misses 2179 2080 -99 ☔ View full report in Codecov by Sentry. |
The missing line is covered in a component test |
generated from commit 7328aad
Description of change
We don't currently have much testing around the OMIS order activities so I've added some. A very minor change was made to the overview summary to better replicate what the previous component was doing.
I've also removed some dead code from the
ActivityFeed
folder as part of the last commit.Checklist