Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for OMIS order activity #7397

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

cgsunkel
Copy link
Contributor

Description of change

We don't currently have much testing around the OMIS order activities so I've added some. A very minor change was made to the overview summary to better replicate what the previous component was doing.

I've also removed some dead code from the ActivityFeed folder as part of the last commit.

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

@cgsunkel cgsunkel requested a review from a team as a code owner December 13, 2024 17:16
Copy link

cypress bot commented Dec 13, 2024

data-hub-frontend    Run #58004

Run Properties:  status check passed Passed #58004  •  git commit 44a0c9ce62: Remove legacy OMIS activity code and other dead AS code
Project data-hub-frontend
Branch Review chore/add-tests-for-omis-activity
Run status status check passed Passed #58004
Run duration 01m 38s
Commit git commit 44a0c9ce62: Remove legacy OMIS activity code and other dead AS code
Committer Christopher
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 15
View all changes introduced in this branch ↗︎

@cgsunkel cgsunkel force-pushed the chore/add-tests-for-omis-activity branch from 2e6ac4b to 44a0c9c Compare December 16, 2024 11:29
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.47%. Comparing base (2bd44ca) to head (44a0c9c).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...yOverview/TableCards/ActivityCards/transformers.js 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7397      +/-   ##
==========================================
+ Coverage   87.98%   88.47%   +0.49%     
==========================================
  Files        1167     1159       -8     
  Lines       18140    18053      -87     
  Branches     5137     5125      -12     
==========================================
+ Hits        15961    15973      +12     
+ Misses       2179     2080      -99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgsunkel
Copy link
Contributor Author

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.47%. Comparing base (2bd44ca) to head (44a0c9c).

Files with missing lines Patch % Lines
...yOverview/TableCards/ActivityCards/transformers.js 88.88% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

The missing line is covered in a component test

@cgsunkel cgsunkel merged commit 7328aad into main Dec 16, 2024
16 checks passed
@cgsunkel cgsunkel deleted the chore/add-tests-for-omis-activity branch December 16, 2024 13:49
chopkinsmade pushed a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants