From 07ac8e180a6315788d27559a336135c05868fd5d Mon Sep 17 00:00:00 2001
From: Haresh Kainth <haresh.kainth@businessandtrade.gov.uk>
Date: Sun, 1 Dec 2024 19:59:26 +0000
Subject: [PATCH] chore:minor refactoring and removed unused endpoint

---
 fbr/cache/public_gateway.py |  2 +-
 fbr/config/urls.py          | 36 ------------------------------------
 2 files changed, 1 insertion(+), 37 deletions(-)

diff --git a/fbr/cache/public_gateway.py b/fbr/cache/public_gateway.py
index d714876..fd1eb06 100644
--- a/fbr/cache/public_gateway.py
+++ b/fbr/cache/public_gateway.py
@@ -86,7 +86,7 @@ def build_cache(self, config):
                 row["date_valid"] = convert_date_string_to_obj(
                     row.get("date_valid")
                 )
-                row["id"] = (generate_short_uuid(),)
+                row["id"] = generate_short_uuid()
 
                 row["publisher_id"] = (
                     None
diff --git a/fbr/config/urls.py b/fbr/config/urls.py
index d7a0553..0ab1934 100644
--- a/fbr/config/urls.py
+++ b/fbr/config/urls.py
@@ -1,7 +1,6 @@
 """Find business regulations URL configuration."""
 
 import logging
-import time
 
 from rest_framework import routers, serializers, status, viewsets
 from rest_framework.decorators import action
@@ -14,9 +13,7 @@
 import core.views as core_views
 import search.views as search_views
 
-from search.config import SearchDocumentConfig
 from search.models import DataResponseModel
-from search.utils.documents import clear_all_documents
 from search.utils.search import get_publisher_names, search
 
 urls_logger = logging.getLogger(__name__)
@@ -91,38 +88,6 @@ def search(self, request, *args, **kwargs):
             )
 
 
-class RebuildCacheViewSet(viewsets.ViewSet):
-    @action(detail=False, methods=["post"], url_path="rebuild")
-    def rebuild_cache(self, request, *args, **kwargs):
-        from search.legislation import Legislation
-        from search.public_gateway import PublicGateway
-
-        tx_begin = time.time()
-        try:
-            clear_all_documents()
-            config = SearchDocumentConfig(search_query="", timeout=20)
-            Legislation().build_cache(config)
-            PublicGateway().build_cache(config)
-        except Exception as e:
-            return Response(
-                data={"message": f"[urls] error clearing documents: {e}"},
-                status=status.HTTP_500_INTERNAL_SERVER_ERROR,
-            )
-
-        tx_end = time.time()
-        urls_logger.info(
-            f"time taken to rebuild cache: "
-            f"{round(tx_end - tx_begin, 2)} seconds"
-        )
-        return Response(
-            data={
-                "message": "rebuilt cache",
-                "duration": round(tx_end - tx_begin, 2),
-            },
-            status=status.HTTP_200_OK,
-        )
-
-
 class PublishersViewSet(viewsets.ViewSet):
     @action(detail=False, methods=["get"], url_path="publishers")
     def publishers(self, request, *args, **kwargs):
@@ -151,7 +116,6 @@ def publishers(self, request, *args, **kwargs):
 # Routers provide an easy way of automatically determining the URL conf.
 router = routers.DefaultRouter()
 router.register(r"v1", DataResponseViewSet, basename="search")
-router.register(r"v1/cache", RebuildCacheViewSet, basename="rebuild")
 router.register(r"v1/retrieve", PublishersViewSet, basename="publishers")
 
 urlpatterns = [