Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to build on RC Python releases #146

Closed
stefanor opened this issue Sep 19, 2024 · 1 comment · Fixed by #147
Closed

Fails to build on RC Python releases #146

stefanor opened this issue Sep 19, 2024 · 1 comment · Fixed by #147

Comments

@stefanor
Copy link 

============================= test session starts ==============================
platform linux -- Python 3.13.0rc2, pytest-8.3.3, pluggy-1.5.0 -- /usr/bin/python3.13
cachedir: .pytest_cache
rootdir: /<<PKGBUILDDIR>>
configfile: pyproject.toml
plugins: typeguard-4.3.0
collecting ... collected 0 items / 1 error

==================================== ERRORS ====================================
_____________________ ERROR collecting test_stream_zip.py ______________________
../../../test_stream_zip.py:1391: in <module>
    tuple(int(v) for v in platform.python_version().split('.')) < (3,7,0),
../../../test_stream_zip.py:1391: in <genexpr>
    tuple(int(v) for v in platform.python_version().split('.')) < (3,7,0),
E   ValueError: invalid literal for int() with base 10: '0rc2'
=========================== short test summary info ============================
ERROR ../../../test_stream_zip.py - ValueError: invalid literal for int() wit...
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 0.22s ===============================

Can I suggest:

sys.version_info[:2] < (3, 7)
michalc added a commit that referenced this issue Sep 20, 2024
@michalc
tests: fix for release candidates (and test on more versions of Python)
5b3ea05 
Fixes #146
@michalc michalc mentioned this issue Sep 20, 2024
Merged
michalc added a commit that referenced this issue Sep 20, 2024
@michalc
tests: fix for release candidates (and test on more versions of Python)
7f2d73f 
Fixes #146
michalc added a commit that referenced this issue Sep 20, 2024
@michalc
tests: fix for release candidates (and test on more versions of Python)
a648dd5 
Fixes #146
michalc added a commit that referenced this issue Sep 20, 2024
@michalc
tests: fix for release candidates (and test on more versions of Python)
76d0283 
Fixes #146
michalc added a commit that referenced this issue Sep 20, 2024
@michalc
tests: fix for release candidates (and test on more versions of Python)
66d6c2e 
Fixes #146
michalc added a commit that referenced this issue Sep 20, 2024
@michalc
tests: fix for release candidates (and test on more versions of Python)
a4d019f 
Fixes #146
michalc added a commit that referenced this issue Sep 20, 2024
@michalc
tests: fix for release candidates (and test on more versions of Python)
372c55f 
Fixes #146
michalc added a commit that referenced this issue Sep 20, 2024
@michalc
tests: fix for release candidates (and test on more versions of Python)
17b69c7 
Fixes #146

Includes lessining the constraints on versions used to run tests in CI (e.g.
pytest, coverage) since the older versions don't seem to work on newer Python.
Specifically, coverage 6.2 bombs out with an error on Python 3.11)
michalc added a commit that referenced this issue Sep 20, 2024
@michalc
tests: fix for release candidates (and test on more versions of Python)
4a0e29c 
Fixes #146

Fixes #146

Includes loosening the constraints on versions used to run tests in CI (e.g.
pytest, coverage) since the older versions don't seem to work on newer Python.
Specifically, coverage 6.2 bombs out with an error on Python 3.11)
michalc added a commit that referenced this issue Sep 20, 2024
@michalc
tests: fix for release candidates (and test on more versions of Python)
26203f2 
Fixes #146

Fixes #146

Includes loosening the constraints on versions used to run tests in CI (e.g.
pytest, coverage) since the older versions don't seem to work on newer Python.
Specifically, coverage 6.2 bombs out with an error on Python 3.11)
michalc added a commit that referenced this issue Sep 20, 2024
@michalc
tests: fix for release candidates (and test on more versions of Python)
a936d5d 
Fixes #146

Includes loosening the constraints on versions used to run tests in CI (e.g.
pytest, coverage) since the older versions don't seem to work on newer Python.
Specifically, coverage 6.2 bombs out with an error on Python 3.11)
michalc added a commit that referenced this issue Sep 20, 2024
@michalc
tests: fix for release candidates (and test on more versions of Python)
c53ce72 
Fixes #146

Includes loosening the constraints on versions used to run tests in CI (e.g.
pytest, coverage) since the older versions don't seem to work on newer Python.
Specifically, coverage 6.2 bombs out with an error on Python 3.11)
@michalc
Copy link
Member

michalc commented Sep 20, 2024

Hi @stefanor,

Thanks for the report + suggestion! Fixed in #147 and released in v0.0.83

Michal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: fix for release candidates (and test on more versions of Python) uktrade/stream-zip
2 participants
@michalc @stefanor