-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seemingly parsing issues with MLFF and VASP 6.4.1 #47
Comments
@Alexyjones My latest version of VASP to test is 6.3.2 so I'm not 100% sure if there are more issues than the one you noticed, but it should be related to vasp-interactive/vasp_interactive/utils.py Line 199 in 3e82db2
Previously this line "ML FREE ENERGIE OF THE ION-ELECTRON SYSTEM (eV)" is in lower case and the new output in 6.4.1 does not match the pattern. If that's the only issue we faced, you can try one your side by changing the following line from your local copy vasp-interactive/vasp_interactive/utils.py Line 212 in 3e82db2
newline = re.sub(pat, rep, newline, 0, re.MULTILINE | re.IGNORECASE) hopefully that will make the parser more flexible. Due to unforeseeable changes in VASP MLFF outputs, I'd recommend sticking to the latest supported version (6.3.2) if possible. If your local changes solve your issue, I appreciate if you provide an example OUTCAR file for us to put in unit test. Of course, PRs always welcome! |
@alchem0x2A Thank you so much for your swift reply. I had to switch to VASP 6.4.1 as the MLFF received a tremendous boost in performance in that version, but the force field is not compatible anymore with older VASP versions.
It seems, that it just gets stuck, when VASP is waiting for a new set of coordinates. I tried your fix with IGNORECASE, but it didn't resolve the issue. I paste here the last few lines of the files, while vasp is waiting for stdin:
vasp.out:
vasprun.xml:
Sadly I failed to see, where exactly it fails. ASE seems to fail to parse the OUTPUT due to the lack of SCF iterations as it searches for the keyword "Iteration", which is completely absent. But I am not sure if this is the issue preventing VASP_interactive from proceeding. P.S. I noted that one "ML" survives the translation: vasp-interactive/vasp_interactive/utils.py Line 204 in 3e82db2
So in my case the parsed OUTCAR becomes:
However fixing this did not change my problem... |
I have to add, that also normal calculations are broken. Just tested a standard calculation of ch4 and the same result- VASP interactive gets stuck at the point when reading from stdin. |
@Alexyjones By accessing the source code, vasp 6.4.1 has a significant change of you can confirm this by finding the following line in your vasp.out using vasp 6.4.1
instead of the old
this is both good and bad new for this package. VASP >=6.4.1 (hopefully no huge changes to INPOS in later versions) should fully support vasp-interactive's functions without need to patch the source code, but more logic need to be put in the source to make it work (a lot of stdout patterns are changed). Due to my other projects at the moment (I'm not actively using vasp MLFF),the bug fix / test may take me a few weeks to finish. Meanwhile, if you have the bandwidth to submit PRs please feel free to do so |
@alchem0x2A I had a similar conclusion yesterday evening, when looking at the production of the stdin routine in vast-interactive. I can confirm that the last line in vasp.out that I see is:
I had applied the patch.py before compiling. |
I just tried to use MLFF with VASP 6.4.1 and VASP interactive gets stuck at the update of coordinates, which was still working with VASP 6.4.0. I copy my energy lines from OUTCAR here, in the hope that somebody may spot the issue:
The text was updated successfully, but these errors were encountered: