Skip to content

fix: wrong stats on event page #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: wrong stats on event page #3609

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c950610
fix: wrong stats on event page
basbroek Sep 4, 2025
b8b773a
fix: add table prefix
basbroek Sep 4, 2025
c924ef8
fix: align clickhouse with prisma query
basbroek Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions src/queries/sql/sessions/getWebsiteSessionStats.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ async function relationalQuery(
return rawQuery(
`
select
count(*) as "pageviews",
count(distinct website_event.session_id) as "visitors",
count(distinct website_event.visit_id) as "visits",
count(distinct session.country) as "countries",
sum(case when website_event.event_type = 2 then 1 else 0 end) as "events"
count(*) filter (where website_event.event_type = 1) as "pageviews",
count(distinct website_event.session_id) filter (where website_event.event_type = 1) as "visitors",
count(distinct website_event.visit_id) filter (where website_event.event_type = 1) as "visits",
count(distinct session.country) filter (where website_event.event_type = 1) as "countries",
count(*) filter (where website_event.event_type = 2) as "events"
from website_event
${cohortQuery}
join session on website_event.session_id = session.session_id
Expand Down Expand Up @@ -62,30 +62,30 @@ async function clickhouseQuery(
sql = `
select
sumIf(1, event_type = 1) as "pageviews",
uniq(session_id) as "visitors",
uniq(visit_id) as "visits",
uniq(country) as "countries",
sum(length(event_name)) as "events"
uniqIf(session_id, event_type = 1) as "visitors",
uniqIf(visit_id, event_type = 1) as "visits",
uniqIf(country, event_type = 1) as "countries",
sumIf(1, event_type = 2) as "events"
from website_event
${cohortQuery}
where website_id = {websiteId:UUID}
and created_at between {startDate:DateTime64} and {endDate:DateTime64}
${filterQuery}
`;
and created_at between {startDate:DateTime64} and {endDate:DateTime64}
${filterQuery}
`;
} else {
sql = `
select
sum(views) as "pageviews",
uniq(session_id) as "visitors",
uniq(visit_id) as "visits",
uniq(country) as "countries",
sum(length(event_name)) as "events"
sumIf(views, event_type = 1) as "pageviews",
uniqIf(session_id, event_type = 1) as "visitors",
uniqIf(visit_id, event_type = 1) as "visits",
uniqIf(country, event_type = 1) as "countries",
sumIf(1, event_type = 2) as "events"
from website_event_stats_hourly website_event
${cohortQuery}
where website_id = {websiteId:UUID}
and created_at between {startDate:DateTime64} and {endDate:DateTime64}
${filterQuery}
`;
and created_at between {startDate:DateTime64} and {endDate:DateTime64}
${filterQuery}
`;
}

return rawQuery(sql, params);
Expand Down