Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite editing in the Media Section when navigating deep into Media Folders #18403

Open
marcemarc opened this issue Feb 20, 2025 · 1 comment
Labels

Comments

@marcemarc
Copy link
Contributor

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

v15.2.1

Bug summary

Gosh, is this a bug or is it by design? I'm reporting it, I don't have a strong reason to call it a bug, but just seemed quirky from the UX point of view, and I don't have any editor feedback on this one to say that this made them sad or anything, so feel free to close if this is intended behaviour...

If you go to the Media Section, and you have a few folders within folders, you can use the left-hand tree to dig down into your deep folder - whenever you click on a folder, the 'workspace' is updated to be the contents of that Media Folder, all is as expected...

... but if you click on a folder in the workspace, on its grid block, or listing - instead of opening that folder, as the media folder on the workspace, it opens up the media folder in an infinite editing window...

like you were performing a picker journey in the media picker... it didn't used to do that!

As I describe this, I'm thinking this is intended?

when you choose a folder from the tree or an image from the tree, it loads the full workspace with the selected item... but when you start the journey from inside the workspace the feeling is to follow the infinite editing paradigm, and stack on top rather than leaving the context of the loaded workspace...

the only thing that's weird, is that once you've started off on this folder sojourn and you think, no I meant the other folder you can't use the 'tree' to switch to the place you want to be, or the search? you have to close each stacked layer one by one? or weirdly if you use the breadcrumb to go back that quits infinite editing and loads the folder on the workspace like if you'd selected it from the tree...

Also clicking on 'Media' at the top of the tree doesn't take you back to the Media Root anymore :-(

... if you use the Media Link in the breadcrumb in the infinite editing it does, but it goes to the URL: /umbraco/section/media/workspace/media-root/edit/null/null and doesn't load any content in the workspace for the media section... is that a separate issue? (it works inside the Media Picker) - I mean if the infinite editing shouldn't be firing here, then the breadcrumb 'Media link' isn't a bug - if infinite editing is the new way to navigate within a workspace inside the Media section, then it is a bug!!

You want a video right?

V15 Behaviour

infinite-editing-in-media-v15.mp4

V13 Behaviour

infinite-editing-in-media-v13.mp4

Specifics

Media section innit

Steps to reproduce

Create a Folder within a Folder within A Folder within a Folder within a Folder and upload some images into it.

Now Load the Media Section

Use the Tree on the left to navigate down to one of the folders, click on the folder in the tree, the workspace will display the contents of the folder
Click on an image in the tree, the image will form the workspace

All cool

Now go back to the top of the Media Section (mourn the loss of the 'Media' root item in the Media tree no longer being a link back to the Media tree root - instead click the Media Section!

Now navigate down to your images, clicking on the folders listed inside the workspace, notice at each depth infinite editing is used, does this feel right? try and switch to a different folder in the tree, or revert to do a media search.... this is maybe by design, you are focussed on finding your Media - no distractions, and it might feel totally natural, but then clicking an item in the breadcrumb should keep you within the infinite editing?, and if it shouldn't and breaking out of infinite editing is the desired outcome when you click the breadcrumb - then clicking on the 'Media' Link in the breadcrumb should take you to the root of the media section with content loaded... so I think there is a bug either which way around that it should be... ???

Expected result / actual result

I'm sort of ambivalent, but I think I'd expect it not to use infinite editing when clicking on a folder in the workspace grid or list, but I don't know if that's because that's not how it used to work in V13 and I'm totally closed off to change and innovation!!! But if infinite editing 'is the way' I'd expect the breadcrumb to stay within infinite editing? or if that's a little complicated to do, then the Media link in breadcrumb should reload the Media section properly! phew!

Copy link

Hi there @marcemarc!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant