Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Update NPM packages used to remove reported vulnerabilities #4846

Closed
PeteDuncanson opened this issue Mar 4, 2019 · 9 comments
Closed
Labels
community/pr status/stale Marked as stale due to inactivity

Comments

@PeteDuncanson
Copy link
Contributor

Just tried to get V8 up and running and a "npm install" reported 60+ vulnerabilities that could be fixed.

@PeteDuncanson
Copy link
Contributor Author

image

@PeteDuncanson
Copy link
Contributor Author

I've got most of these fixed. The remaining ones are in gulp-ngdocs which is no longer maintained (see nikhilmodak/gulp-ngdocs#120) and only used for dev I think (something to look into) but they shouldn't be bundled in the back office at all.

Now down to 17 issues.

image

@PeteDuncanson
Copy link
Contributor Author

If we wanted to fix it any more I'd suggest a PR to gulp-ngdocs but can't say I'm sure there would be anyone around to merge it in and do another release...could probably live with it.

@nul800sebastiaan
Copy link
Member

Thanks so far @PeteDuncanson - are you making any progress on the gulp update yet?

As for docs, they don't work at the moment anyway and we'll need to find an alternative, so don't worry about that one.

@PeteDuncanson
Copy link
Contributor Author

Had a play with it and will be working on it more so you know.

@PeteDuncanson PeteDuncanson changed the title Update NPM packages used to remove reported vulnerabilities V8: Update NPM packages used to remove reported vulnerabilities Mar 22, 2019
@readingdancer
Copy link
Contributor

readingdancer commented Jul 8, 2019

I've just submitted a pull request that updates Gulp to V4 and removes most of the vulnerabilities, let me know what you think?

As the Docs are not working, for now I think we might as well remove that section, what do you think @nul800sebastiaan & @PeteDuncanson ?

@PeteDuncanson
Copy link
Contributor Author

Great work @readingdancer! It was discussed at one of the open spaces that docs are meant to now be "fixed". Not tried them myself since, are they broken again/still?

Either way the plan is to keep docs going and fix/improve them so I'd recommend leaving those in.

@umbrabot
Copy link

Hiya @PeteDuncanson,

Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.

We will close this issue for now but we're happy to open it up again if you think it's still relevant (for example: it's a feature request that's not yet implemented, or it's a bug that's not yet been fixed).

To open it this issue up again, you can write @umbrabot still relevant in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it's still relevant.

For example:

@umbrabot still relevant
This bug can still be reproduced in version x.y.z

This will reopen the issue in the next few hours.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@umbrabot umbrabot added the status/stale Marked as stale due to inactivity label Jan 12, 2021
@readingdancer
Copy link
Contributor

@PeteDuncanson - I just saw this, good to know that it was integrated with some more changes from HQ :)

#6809

I don't think I saw that back in 2019 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community/pr status/stale Marked as stale due to inactivity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants