From 37f5cf16bdcae96ead887f604bb932e18cbd7658 Mon Sep 17 00:00:00 2001 From: Marcin Cuber Date: Thu, 21 May 2020 09:40:52 +0100 Subject: [PATCH] Update security group configuration with lifecycle and revoke (#2) --- .pre-commit-config.yaml | 2 +- CHANGELOG.md | 18 +++++++++++++++--- README.md | 2 +- main.tf | 6 ++++++ 4 files changed, 23 insertions(+), 5 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index ca22696..66adb9b 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -1,6 +1,6 @@ repos: - repo: https://github.com/pre-commit/pre-commit-hooks - rev: v2.5.0 + rev: v3.1.0 hooks: - id: check-added-large-files args: ['--maxkb=500'] diff --git a/CHANGELOG.md b/CHANGELOG.md index 489378f..1ab65e4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,13 +5,23 @@ All notable changes to this project will be documented in this file. ## [Unreleased] -- address comments format and use of tags in example -- add changes to support additional tags for cluster and cluster instance + + + +## [1.1.0] - 2020-05-04 + +- add changes to support additional tags for cluster and cluster instance ([#1](https://github.com/umotif-public/terraform-aws-rds-aurora/issues/1)) - update CHANGELOG - update config for chglog - Add changelog + +## [1.0.1] - 2020-04-21 + +- Add changelog + + ## 1.0.0 - 2020-04-20 @@ -19,4 +29,6 @@ All notable changes to this project will be documented in this file. - Initial commit -[Unreleased]: https://github.com/umotif-public/terraform-aws-rds-aurora/compare/1.0.0...HEAD +[Unreleased]: https://github.com/umotif-public/terraform-aws-rds-aurora/compare/1.1.0...HEAD +[1.1.0]: https://github.com/umotif-public/terraform-aws-rds-aurora/compare/1.0.1...1.1.0 +[1.0.1]: https://github.com/umotif-public/terraform-aws-rds-aurora/compare/1.0.0...1.0.1 diff --git a/README.md b/README.md index 24f3b3f..ef99186 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,7 @@ Terraform 0.12. Pin module version to `~> v1.0`. Submit pull-requests to `master ```hcl module "rds-aurora-mysql" { source = "umotif-public/rds-aurora/aws" - version = "~> 1.0.0" + version = "~> 1.2.0" name_prefix = "example-aurora-mysql" engine = "aurora-mysql" diff --git a/main.tf b/main.tf index 4178b23..a3e4543 100644 --- a/main.tf +++ b/main.tf @@ -14,6 +14,12 @@ resource "aws_security_group" "main" { Name = "${var.name_prefix}-sg" } ) + + revoke_rules_on_delete = true + + lifecycle { + create_before_destroy = true + } } resource "aws_security_group_rule" "main_egress" {