Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand test case coverage, improve existing tests #21

Open
7 tasks
AdamBJ opened this issue Apr 10, 2017 · 15 comments
Open
7 tasks

Expand test case coverage, improve existing tests #21

AdamBJ opened this issue Apr 10, 2017 · 15 comments

Comments

@AdamBJ
Copy link
Contributor

AdamBJ commented Apr 10, 2017

  • Multiple languages specified for a single build file
  • Multiple master files specified for a single build
  • Ruby, Sql, C++, Php generation tests
  • Test that master file paths are being generated properly, even in a sub project. See 40d6eca#commitcomment-21693148
  • Test that autoboxing is working correctly for boolean <-> Boolean when it comes to nulls. See 026d14e#commitcomment-21688720
  • Make Travis green
  • Get rid of the hard coded strings in the existing test's assertEquals calls
AdamBJ referenced this issue Apr 10, 2017
…of testing. Other minor changes

- New style follows best practices for Property (no direct calls to put and get)
- Gets rid of a good number of hard coded strings
- Less calls to toString(), though we're still using strings in the assertEquals stuff
- Enabled printing to system out for the `test` task
@AdamBJ
Copy link
Contributor Author

AdamBJ commented May 13, 2017

@Nava2 Hey Kevin, I've got my plans more-or-less set for summer now. I'll be working full time, but would still like to continue with the test case stuff for the plugin we discussed at the end of last semester.

Unfortunately, my hard drive failed earlier this week, and with it went the development Gradle/Umple development environment. I'm going to try and get it up-and-running again, but my bandwidth over the summer will be limited. What're you plans for the summer? Are you planning to put any time in on Umple/Gradle?

@Nava2
Copy link
Contributor

Nava2 commented May 15, 2017

So, I want to do some work on this project, getting it closer -- but I'm hurting for time with finishing up my thesis. I can probably take a more hands-off approach than I was before. I can also answer emails and do little things. 👍

@AdamBJ
Copy link
Contributor Author

AdamBJ commented Jul 15, 2017

One thing we should address is how master is still something like 19 commits behind ss-config-n2. Hopefully we can merge it into master before the summer is over, but if we don't we should put out some big, loud signposts for whoever is working on this next. Wouldn't want them to start working on the master branch.

@AdamBJ
Copy link
Contributor Author

AdamBJ commented Jul 15, 2017

My goal for the summer is:

  1. Make sure the job of whoever starts on this project next is as easy as possible. Cleanup readme, add quickstart section etc so that the next person can get up and running as quickly as possible.
  2. Check off as many of the boxes in the above list as possible.

@AdamBJ
Copy link
Contributor Author

AdamBJ commented Aug 21, 2017

@Nava2 what version of gradle are you using when working with the Umple plugin? I've been getting some weird org.gradle.tooling.BuildException: Could not execute build using Gradle distribution 'https://services.gradle.org/distributions/gradle-3.4.1-bin.zip'. errors and am wondering if it's because I've upgraded to a newer version of gradle.

@AdamBJ
Copy link
Contributor Author

AdamBJ commented Aug 23, 2017

Never mind, it was related to another issue.

@Nava2
Copy link
Contributor

Nava2 commented Aug 23, 2017

Good because I also forgot to reply.. 😥

@AdamBJ
Copy link
Contributor Author

AdamBJ commented Aug 24, 2017

@Nava2 Alright, I think I've fixed the problem I was having, but I've come across something perplexing. If I recall correctly, the command:

$ java -jar umple-latest.jar -c -g master.ump

Should generate whichever .java files are encoded by master.ump, and then compile them into .class files. However, I'm only getting .java files out right now. What gives? It's messing with the gradle test cases because the way we set it up we look for both .java and .class files when compileGenerated is set (which is it by default).

@Nava2
Copy link
Contributor

Nava2 commented Aug 24, 2017

I don't think Umple uses javac at all. So, just Java is the expectation.

@Nava2
Copy link
Contributor

Nava2 commented Aug 24, 2017

I actually built this awhile ago, it might be useful to read through it. I did many of the things I wanted to so with this plugin within.

https://github.com/assertj/assertj-generator-gradle-plugin

I have some other projects to finish at the moment (Masters' defence is on Monday), but I can probably look at this shortly. 👍

@AdamBJ
Copy link
Contributor Author

AdamBJ commented Aug 24, 2017

Wow! Good luck on Monday! I'll have a look at the other plugin as I (hopefully) start adding more tests in the coming days.

Here are the lines that check for the .class files:

builder.put(DIRECTORIES_ROOT + "subproj/build/classes/generatedSource", ["Subproj.class", "Subproj2.class"])

Were we doing something extra to compile the .java files? I can't remember.

@TimLethbridge
Copy link
Member

Inr reply to the earlier question. The correct way to compile is

java -jar umple-latest.jar master.ump

That will generate java files (no -c or -g options)

If you want classfiles then

java -jar umple-latest.jar -c - master.ump

@Nava2
Copy link
Contributor

Nava2 commented Aug 24, 2017

My memory failed me, thanks @TimLethbridge.

@TimLethbridge
Copy link
Member

No I mean -c - not -c -g

@TimLethbridge
Copy link
Member

Sorry I was responding to what I think was a private message where I was asked if my comments were correct. I don't see that message above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants