Skip to content
This repository has been archived by the owner on Aug 31, 2019. It is now read-only.

Incorrect network detection #348

Open
werebus opened this issue Apr 1, 2017 · 5 comments
Open

Incorrect network detection #348

werebus opened this issue Apr 1, 2017 · 5 comments

Comments

@werebus
Copy link
Member

werebus commented Apr 1, 2017

Ran into this, this evening:

screenshot_20170331-201303

Note the full wifi and cellular signal. I also confirmed that I could access the web with Chrome. Killing and restarting the app fixed it, but I couldn't get it to check again otherwise.

@werebus werebus added the bug label Apr 1, 2017
@akaplo
Copy link

akaplo commented Apr 1, 2017

Interesting. Not sure why that happened.

@werebus
Copy link
Member Author

werebus commented Apr 1, 2017

I think this may be another backgrounding issue. I'm not 100% sure, but I think I opened the app somewhere where I didn't have a network connection, but the app wasn't in the foreground when the network came back again. ❓

@akaplo
Copy link

akaplo commented Apr 2, 2017

Can't reproduce on my 5X; we'll talk in person.

@akaplo
Copy link

akaplo commented Apr 7, 2017

One thing we can both reproduce is backgrounding the app, toggling internet off/on a few times, and reopening the app. Upon doing so, the "no interwebs" Toast will pop in and out as many times as the phone lost connection.

Will fix by adding a global "pause/resume" listener to stop the global "no internet?" listener.

@akaplo
Copy link

akaplo commented Apr 13, 2017

Think I finally managed to reproduce @werebus original bug. If a network change occurrs WHILE the app is loading, it might simply never think you have Internet.

@mboneil10 mboneil10 assigned mboneil10 and unassigned mboneil10 Jul 29, 2017
@mboneil10 mboneil10 self-assigned this Mar 20, 2018
@mboneil10 mboneil10 removed their assignment Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants