Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

157 feature create behavior leave parking space #162

Merged
merged 9 commits into from
Jan 19, 2024
Merged

157 feature create behavior leave parking space #162

merged 9 commits into from
Jan 19, 2024

Conversation

samuelkuehnel
Copy link
Collaborator

@samuelkuehnel samuelkuehnel commented Jan 14, 2024 •
edited
Loading

Description

This change introduces a new behavior to leave the parking space. It also contains some fixes regarding the Collision Check.
It also contains the documentation for the frenet trajectory planner
Fixes #157

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Does this PR introduce a breaking change?

No

Most important changes

New Behavior "Leave Parking space"

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
  • New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

@samuelkuehnel samuelkuehnel self-assigned this Jan 14, 2024
@samuelkuehnel samuelkuehnel linked an issue Jan 14, 2024 that may be closed by this pull request
[Feature]: Create behavior "leave parking space" #157
Closed
1 task
@github-actions GitHub Actions
Copy link

Simulation results

Metric Value
Avg. driving score 0.134853
Avg. route completion 7.145
Avg. infraction penalty 0.057763
Collisions with pedestrians 1.022
Collisions with vehicles 7.152
Collisions with layout 3.065
Red lights infractions 0.0
Stop sign infractions 3.065
Off-road infractions 0
Route deviations 1.022
Route timeouts 1.022
Agent blocked 0.0
Yield emergency vehicles infractions 0.0
Scenario timeouts 2.043
Min speed infractions 0.0

@ll7
Copy link
Member

ll7 commented Jan 19, 2024

Any ideas while the drive command failes?

@github-actions GitHub Actions
Copy link

Simulation results

Metric Value
Avg. driving score 0.236247
Avg. route completion 8.835
Avg. infraction penalty 0.048818
Collisions with pedestrians 2.397
Collisions with vehicles 10.389
Collisions with layout 2.397
Red lights infractions 0.799
Stop sign infractions 2.397
Off-road infractions 0.011
Route deviations 0.799
Route timeouts 0.0
Agent blocked 0.799
Yield emergency vehicles infractions 0.0
Scenario timeouts 0.799
Min speed infractions 0.0

@samuelkuehnel
Copy link
Collaborator Author

samuelkuehnel commented Jan 19, 2024 •
edited
Loading

Any ideas while the drive command failes?

The issue seems to be the emergency brake bug I mentioned last monday. I wasn't able to fix it and forgot to disable the emergency brake function. The new drive action finished successfully.

JuliusMiller
JuliusMiller approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@JuliusMiller JuliusMiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice Driving Score 👍

@JuliusMiller JuliusMiller merged commit 6fd0475 into main Jan 19, 2024
3 checks passed
@JuliusMiller JuliusMiller deleted the 157-feature-create-behavior-leave-parking-space branch January 19, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliusMiller JuliusMiller JuliusMiller approved these changes

Assignees

@samuelkuehnel samuelkuehnel

Labels
planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Create behavior "leave parking space"
3 participants
@samuelkuehnel @ll7 @JuliusMiller