Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix class names with filter-? #159

Open
tomByrer opened this issue Mar 2, 2016 · 5 comments
Open

Prefix class names with filter-? #159

tomByrer opened this issue Mar 2, 2016 · 5 comments

Comments

@tomByrer
Copy link
Contributor

tomByrer commented Mar 2, 2016

Advantages:

  • prevents an onboarding devs say "What the ___ is 'hudson'?"
  • allows global search/replace/delete

Disadvantages:

  • larger files (mostly negated by gzip)
  • more typing (reduced by editors' autocomplete, copy/paste|search/replace
  • add extra coding to gulpfile

Could prefix with cssgram- also, less clear, but helps in finding this repo.

@henryruhs
Copy link

1+

@una
Copy link
Owner

una commented Mar 21, 2016

Hey @tomByrer -- I agree with namespacing being a good idea for semantic understanding. My biggest concern with this is that it would be a breaking change to the previous workflow and would affect everyone who has already implemented the library. The question here is -- is that tradeoff worth it?

@Effeilo
Copy link

Effeilo commented Mar 27, 2016

1+
Another advantage, it will ease the code. for example

[class*="cssgram-"] {
  position: relative;
}

[class*="cssgram-"]:before, 
[class*="cssgram-"]:after {
  content: '';
  display: block;
  height: 100%;
  width: 100%;
  top: 0;
  left: 0;
  position: absolute;
  pointer-events: none;
}

[class*="cssgram-"] > img {
  width: 100%;
  z-index: 1;
}

[class*="cssgram-"]:before {
  z-index: 2;
}

[class*="cssgram-"]:after {
  z-index: 3;
}

@tomByrer
Copy link
Contributor Author

@una Could keep the old class names, & make *.prefix.css|scss` files.
@Effeilo good ideas

@una
Copy link
Owner

una commented Apr 12, 2016

@Effeilo I really like what you did there -- it would reduce redundant code. This is definitely swaying me toward the prefixed version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants