-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefix class names with filter-
?
#159
Comments
1+ |
Hey @tomByrer -- I agree with namespacing being a good idea for semantic understanding. My biggest concern with this is that it would be a breaking change to the previous workflow and would affect everyone who has already implemented the library. The question here is -- is that tradeoff worth it? |
1+ [class*="cssgram-"] {
position: relative;
}
[class*="cssgram-"]:before,
[class*="cssgram-"]:after {
content: '';
display: block;
height: 100%;
width: 100%;
top: 0;
left: 0;
position: absolute;
pointer-events: none;
}
[class*="cssgram-"] > img {
width: 100%;
z-index: 1;
}
[class*="cssgram-"]:before {
z-index: 2;
}
[class*="cssgram-"]:after {
z-index: 3;
} |
@Effeilo I really like what you did there -- it would reduce redundant code. This is definitely swaying me toward the prefixed version |
Advantages:
Disadvantages:
gulpfile
Could prefix with
cssgram-
also, less clear, but helps in finding this repo.The text was updated successfully, but these errors were encountered: