Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs content #39

Open
3 tasks
Tracked by #37
amirhouieh opened this issue Sep 24, 2024 · 17 comments
Open
3 tasks
Tracked by #37

Update docs content #39

amirhouieh opened this issue Sep 24, 2024 · 17 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request task

Comments

@amirhouieh
Copy link
Member

amirhouieh commented Sep 24, 2024

We need to read through the documentation and look for

  • Outdated content, examples, and snippet codes
  • Mistakes and irrelevant content
  • Missing content (e.g; Typescript examples)
@amirhouieh amirhouieh added documentation Improvements or additions to documentation enhancement New feature or request task labels Sep 24, 2024
@github-project-automation github-project-automation bot moved this to Icebox in Roadmap Sep 24, 2024
@amirhouieh amirhouieh changed the title Content Update docs content Sep 24, 2024
@Aashish-Upadhyay-101
Copy link
Contributor

const u = new Unbody({
  apiKey: "<API_KEY>",
  projectId: "<PROJECT_ID>",
});

I have to add the ! at the end of the keys. Is that expected behavior? or that could be changed in the SDK definition?

@Aashish-Upadhyay-101
Copy link
Contributor

for semantic search:

example 1, 2 and 3 should have exec function and also must show how to destructure the data as something like this:

  const { data: { payload } } = await unbody.get.googleDoc.search.about("search_string").exec();

@Aashish-Upadhyay-101
Copy link
Contributor

same for Keyword search example:

  const { data: { payload } } = await unbody.get.googleDoc.search.find("search_keyword").exec();

@Aashish-Upadhyay-101
Copy link
Contributor

Aashish-Upadhyay-101 commented Sep 26, 2024

I feel like every code example should also include how you can destructure the output, and every query should have a exec function.

here as well in Semantic search > nearVector search

unbody.get
    .article
    .nearVector({
        vector: [...vector representing “web development”...],
        moveTo: {
            concepts: ["frontend", "backend"],
            force: 0.5
        }
    })
    .exec()

also

nearText and nearVector documentation needs to be updated because nearVector doesn't show any moveTo property.

Image

and the vector property these searches has is very confusing, I don't know what it is trying to convey.

  1. not sure what you mean by "destructure the output"
  2. "vector" is a common concept and plz note these methods are quite advance and surely when a user is using "nearVector" they know what "vector" is. But in general I agree we can improve these parts but they have low propriety for time being!

@Aashish-Upadhyay-101
Copy link
Contributor

SDK has not being updated:

can't perform *Record Similarity Search using SDK

unbody.get.googleDocs.search.similar("id", {...option})

@amirhouieh
Copy link
Member Author

const u = new Unbody({
  apiKey: "<API_KEY>",
  projectId: "<PROJECT_ID>",
});

I have to add the ! at the end of the keys. Is that expected behavior? or that could be changed in the SDK definition?

I did not understand! could you add an example?

@amirhouieh
Copy link
Member Author

SDK has not being updated:

can't perform *Record Similarity Search using SDK

unbody.get.googleDocs.search.similar("id", {...option})

@jeangovil

@jeangovil
Copy link
Member

SDK has not being updated:

can't perform *Record Similarity Search using SDK

unbody.get.googleDocs.search.similar("id", {...option})

That's not the correct syntax, here's the correct way:

unbody.get.googleDoc.similar.record('id', {}).exec()

@Aashish-Upadhyay-101
Copy link
Contributor

@jeangovil then It need to be updated in the docs because the docs has:

unbody.get
    .googleDoc
    .search
    .similar
    .record("specificDocId");

@Aashish-Upadhyay-101
Copy link
Contributor

also in the Generative Search Example 1:

The exact same query as:

unbody.get
    .textBlock
    .generate
    .fromOne("Transform this historical fact into a captivating tweet: {content}")
    .exec()

throws a error as:

[
  {
    locations: [ [Object] ],
    message: 'explorer: list class: extend: extend generate: Prompt does not contain any properties. Use {PROPERTY_NAME} in the prompt to instuct Weaviate which data to use',       
    path: [ 'Get', 'GoogleDoc' ]
  },
  digest: '3288676927'
]

@Aashish-Upadhyay-101
Copy link
Contributor

QnA Example 1:

The same query gives an error as:

Image

@Aashish-Upadhyay-101
Copy link
Contributor

List of Supported Argument:

includeMeta and orderBy is not in the SDK

@Aashish-Upadhyay-101
Copy link
Contributor

No Aggregate Page

@Aashish-Upadhyay-101
Copy link
Contributor

is filters available for javascript SDK?

@Aashish-Upadhyay-101
Copy link
Contributor

does unbody JS-SDK has Image API support?

@amirhouieh
Copy link
Member Author

does unbody JS-SDK has Image API support?

Nope and it does not need one

@amirhouieh
Copy link
Member Author

is filters available for javascript SDK?

https://www.unbody.io/docs/libraries/typescript-client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request task
Projects
Status: In Progress
Development

No branches or pull requests

3 participants