Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React legacy lifecycle method deprecation #58

Open
linuswillner opened this issue Aug 12, 2019 · 3 comments
Open

React legacy lifecycle method deprecation #58

linuswillner opened this issue Aug 12, 2019 · 3 comments

Comments

@linuswillner
Copy link

React recently moved forward with its intent to deprecate and eventually remove unsafe lifecycle methods. This includes componentWillReceiveProps, which this component utilises. As such, usage of this component now triggers a warning in React:

Warning

React has some migration directives here: https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html#updating-state-based-on-props

@unclecheese
Copy link
Owner

Cheers. The whole library should be moved to use hooks, tbh. It's perfectly suited for them.

@edant92
Copy link

edant92 commented Sep 30, 2019

Any timeline on when this might be resolved? Or anything I could do to help out?

@unclecheese
Copy link
Owner

If you submit a PR with the changes, I'll gladly give it a prompt review and merge. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants