-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Needs work for 3.2 #85
Comments
Yeah, there's a bit to fix. I started work on fixing some CMS issues but haven't got it to a 100% working stage yet: |
For the most part, there shouldn't be any API changes. @3Dgoo your changes look good. Fire off a PR when you're ready and I'll merge. I haven't so much as looked at this module in over a year, so I appreciate the effort. |
Happy to help. It's almost ready for a PR. @RuthAdele and I just need to do some final testing to check it works correctly in both 3.2 and 3.1. |
Thank you @3Dgoo, that will be a lifesaver. This has been preventing us from upgrading beyond 3.1 on numerous sites for months. |
I have finally submitted a pull request #99 to fix this module for SilverStripe 3.2 and 3.3. From my testing it now works on versions 3.1, 3.2 and 3.3. I will keep an eye out for any issues that are lodged on github in case anyone finds any problems with the upgrade. |
@3Dgoo is my hero!!! <3 <3 |
Calendar.php (line 438)
return $events->getRange(0,$limit);
the method getRange() doesn't seem to exist anymore.
There are also some other issues affecting the CMS in general. Could use a thorough 3.2 compatibility pass.
The text was updated successfully, but these errors were encountered: