Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Printed AST parsing #32

Closed
atlv24 opened this issue Feb 22, 2024 · 2 comments
Closed

Printed AST parsing #32

atlv24 opened this issue Feb 22, 2024 · 2 comments
Assignees
@BradenEverson
Labels
question Further information is requested

Comments

@atlv24
Copy link
Contributor

atlv24 commented Feb 22, 2024

reverse Context::to_string using nom and strum. This will enable save/load and easier unit testing.

short term we should probably do this via serde and save out the whole context for simplicity.
@Ebanflo42
Copy link
Contributor

I'm not sure I see the motivation behind this? What is gained over just calling all the operations using the context functions?

@BradenEverson BradenEverson added the question Further information is requested label Mar 14, 2024
@BradenEverson BradenEverson self-assigned this Mar 17, 2024
@Ebanflo42
Copy link
Contributor

I would move to close this as I think it will be better for interoperability to save StableHLO strings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BradenEverson BradenEverson

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atlv24 @Ebanflo42 @BradenEverson