Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink error handling? #46

Open
Ebanflo42 opened this issue Mar 8, 2024 · 2 comments
Open

Rethink error handling? #46

Ebanflo42 opened this issue Mar 8, 2024 · 2 comments

Comments

@Ebanflo42
Copy link
Contributor

Currently, all of our tests are littered with .expect, which is really ugly. I would vote to panic from within all user-facing functions. I'm not really sure what the API would gain from doing anything else.

@Ebanflo42
Copy link
Contributor Author

@atlv24 would it make sense for us to have a separate error type for each module? or should we create a src/error.rs to encapsulate every error?

@BradenEverson
Copy link
Member

@Ebanflo42 We could do errors for every module and for anything outward facing use a super-error that can be from any of the smaller errors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants