Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge case: editing a source while its metadata is updated #970

Open
thomaspiller opened this issue Nov 9, 2023 · 1 comment
Open

Edge case: editing a source while its metadata is updated #970

thomaspiller opened this issue Nov 9, 2023 · 1 comment

Comments

@thomaspiller
Copy link
Collaborator

If a publisher alters the structure of a source (add, rename, duplicate, remove column) while another is modifying the metadata of the same source, the structural changes will not be propagated in the metadata stored in mx_sources. This is because the version loaded into the metadata editor predates the structural edits and once saved, they will overwrite the version of the metadata containing the structural changes saved from the table editor.

An approach to avoid this could be to do a check on date_modified to ensure that the source has not been updated in the meantime.

@fxi
Copy link
Member

fxi commented Nov 9, 2023

This issue should probably be resolved once the metadata editor is integrated with the Node.js: editing metadata for a given source will be locked until table editing is completed, and vice versa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants