Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade LifeCycle event componentWillMount to fit newest React Native version #19

Open
clijiac opened this issue Mar 6, 2020 · 0 comments · May be fixed by #20
Open

Upgrade LifeCycle event componentWillMount to fit newest React Native version #19

clijiac opened this issue Mar 6, 2020 · 0 comments · May be fixed by #20

Comments

@clijiac
Copy link

clijiac commented Mar 6, 2020

the newest RN0.61.5 use React 16.9 which will warn when you use componentWillMount etc

Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

  • Move code with side effects to componentDidMount, and set initial state in the constructor.
  • Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.
    Please update the following components: Form
@unexge unexge linked a pull request Mar 7, 2020 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Mark componentWillMounts as unsafe unexge/foect
1 participant
@clijiac