Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilations handling not working? #339

Closed
SiriusVI87 opened this issue May 9, 2024 · 3 comments
Closed

Compilations handling not working? #339

SiriusVI87 opened this issue May 9, 2024 · 3 comments

Comments

@SiriusVI87
Copy link

SiriusVI87 commented May 9, 2024

Describe the bug
I have set the compilation handling option to "keep individual titles and compilations", but after processing my SNES dat file, compilations seem to be preferred over individual titles. The individual titles are missing (e.g.: Super Mario All-Stars + Super Mario World (USA) is kept, but not the individual Super Mario World.)

@unexpectedpanda
Copy link
Owner

The logic is correct, but the clone list had to be updated to change Super Mario All-Stars + Super Mario World from a superset to a compilation. That's done now, update your clone lists and it'll work as expected.

@SiriusVI87
Copy link
Author

Great, thank you! On that note, I believe an option for supersets, similar to the "compilation handling" would be great. Users could chosse to just keep the superset or keep the superset and previous versions also.

To my mind it makes sense that if a cartridge of a game exists, it counts as a distinct title. So I'd like to keep Super Mario All-Stars + Super Mario World, Super Mario All-Stars, and Super Mario World, no matter the first one is considered a comilation or a superset of the latter two titles.

@unexpectedpanda
Copy link
Owner

To my mind it makes sense that if a cartridge of a game exists, it counts as a distinct title. So I'd like to keep Super Mario All-Stars + Super Mario World, Super Mario All-Stars, and Super Mario World, no matter the first one is considered a comilation or a superset of the latter two titles.

That's exactly what the clone list change enables, but I'm guessing you mean if the compilation was still set as a superset.

It looks like you might have missed the post — no new features are coming in the foreseeable future, as Retool is no longer maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants