Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's time for v1!! #889

Closed
thclark opened this issue Dec 1, 2024 · 2 comments
Closed

It's time for v1!! #889

thclark opened this issue Dec 1, 2024 · 2 comments

Comments

@thclark
Copy link

thclark commented Dec 1, 2024

Hi Lukas,

I'm still a big fan of unfold but something that's getting quite frustrating is the versioning system. We've had 20 releases in the last 6 months, all of which are potentially breaking changes :(.

I think most of them aren't, but the commit logs and release notes don't highlight breaking changes, so it's either a case of combing through the code with a fine toothcomb, or crossing fingers.

Please could we move to v1, so you can add new features to your hearts content, but allow us to see if updating would break our backward compatibility?

Thanks!

@soltanoff
Copy link

Hm, I agree with @thclark. It's really useful idea/enhancement.

@lukasvinclav
Copy link
Contributor

lukasvinclav commented Dec 16, 2024

Hey @thclark,

thanks for this question. Actually, I was already thinking about it several times in the past. There are few reasons why I decided NOT to release 1.0:

  • I want to focus on active development adding more and more features based on user feedback. In general, I'm trying to add new stuff without breaking existing implementation. By not breaking, I mean changes will not raise 500.

  • Before commiting to version 1.0, I want to make sure theme contains broader set of features which I'm personaly considering as mandatory.

  • 1.0 release would imply that breaking changes will be minimized in the future but first I have to ensure theme is robust enough

  • I don't feel there is urgent need for 1.0. If you are implementing Unfold in your projects and your are not sure about breaking the project after next update, just pin to the specific version.

@lukasvinclav lukasvinclav pinned this issue Dec 17, 2024
@lukasvinclav lukasvinclav unpinned this issue Dec 28, 2024
@lukasvinclav lukasvinclav closed this as not planned Won't fix, can't repro, duplicate, stale Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants