-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable platform decoder for aac and hevc #2752
Comments
Thanks @uazo! There is one obstacle still: we haven't worked out how are we supposed to include patches from other projects, which are published under a different license other than that of ungoogled-chromium. |
not a problem at all. you are of course authorised to use it. |
As an aside, The Chromium Authors will be introducing platform AC3/E-AC3 (Windows/macOS) in Chrome 124 - check out stazhu and the Chrome 124 betas. WIN11_22H2+ supports platform kXHE_AAC: Enable-platform-aac-audio-and-h264-video.patch breaks that support. Consider the changes that you've made to media/filters/win/media_foundation_audio_decoder.cc; platform kXHE_AAC and kAAC are mutually exclusive in WIN11_22H2+ |
@macchrome thanks for the report!
what is stazhu?
do you mean this?
if |
since you reminded me, I'm sorry I didn't mention it before, I forgot to say: in cromite I still made the decision not to support pass-through codecs being one of the ways to fingerprint the device and indeed this line removes support in android whereas in windows there is a gn flag on purpose. |
Platform xhe-aac not available on Windows 11 < 22H2 - built with your patch and enable_platform_ac3_eac3_audio = true Platform xhe-aac available on Windows 11 >= 22H2 and standard ffmpeg aac - ( enable_platform_ac3_eac3_audio = true) xHE-AAC test page: https://www2.iis.fraunhofer.de/AAC/xhe-aac.html I've also got some bloke complaining: macchrome/winchrome#136 - Discovery+ uses xHE-AAC! |
neither in chrome nor in edge does that codec work (in w11). |
Standard Google Release: Google Chrome: 122.0.6261.39 (Official Build) (64-bit) Just tested https://www2.iis.fraunhofer.de/AAC/xhe-aac.html - test streams all play. My personal GN args (ungoogled): Windows x64 GNU/Linux cross compile: target_os="win" |
I assume the problem is due to these lines:
in the code I find:
Conversely, I enable conversion for all aac streams about the cdm, sorry, but I can't help you with that, it's something I don't know yet. |
I confirm that adding that simple if works. |
Platform audio-visual (AV) decoding under Linux including xHE_ACC |
Description
Remove the licensing problem caused by the possible inclusion of proprietary aac/hevc codec in ffmpeg decoders
Who's implementing?
The problem
I submit to your attention the possibility of enabling, for the time being only for windows and android, the activation of the proprietary codecs aac and hevc using the s.o. libraries, effectively removing the problem of the lack of licence required for the distribution of applications capable of decoding those streams.
I would appreciate your assessment of this and if you are interested in adopting it in ungoogled chromium, it would be a pleasure for me.
The linux version is still at the hypothesis stage, it would be nice to help each other in the development.
Possible solutions
Patch:
Alternatives
No response
Additional context
Context:
The text was updated successfully, but these errors were encountered: