Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache indicator values #2

Closed
jbax opened this issue Nov 22, 2019 · 3 comments
Closed

Cache indicator values #2

jbax opened this issue Nov 22, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request wontfix This will not be worked on
Milestone

Comments

@jbax
Copy link
Member

jbax commented Nov 22, 2019

As suggested in issue #1:

One thing you may want to add in the future for better performance is a caching mechanism for your indicators to reduce repeated computation time. Here's a Java TA library which does this as an example:

https://github.com/ta4j/ta4j

@jbax jbax self-assigned this Nov 22, 2019
@jbax jbax added the enhancement New feature or request label Nov 22, 2019
@jbax jbax added this to the 1.0.0 milestone Nov 22, 2019
@jbax jbax added the wontfix This will not be worked on label Dec 4, 2019
@jbax
Copy link
Member Author

jbax commented Dec 4, 2019

Closing as it may decrease overall performance and add complexity for negative gains. The code required to reuse the values adds a ton of complexity without major gains in performance (in fact, there's more potential of losing performance than gaining any). Indicators with the same time interval and parameters are almost never present. This is even less relevant when indicators that happen to use the same settings use longer intervals (> 5 minutes), as the calculations are pretty cheap. No work needed here at the moment until someone highlights an actual performance bottleneck.

@jbax jbax closed this as completed Dec 4, 2019
@SteveH2003
Copy link

SteveH2003 commented Dec 4, 2019 via email

@jbax
Copy link
Member Author

jbax commented Dec 4, 2019

This is CSS, and maybe what you see concerns charting. Not relevant to the calculation of the indicator value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants