Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify MINIMUM_ALLOWED_NUMBER_CLASSES definition #28

Open
pedropaulofb opened this issue Jan 19, 2023 · 1 comment
Open

Modify MINIMUM_ALLOWED_NUMBER_CLASSES definition #28

pedropaulofb opened this issue Jan 19, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@pedropaulofb
Copy link
Collaborator

pedropaulofb commented Jan 19, 2023

Currently MINIMUM_ALLOWED_NUMBER_CLASSES refers to the TOTAL number of classes a taxonomy has.

However, a taxonomy may have more than MINIMUM_ALLOWED_NUMBER_CLASSES but all their classes can be of type "other" and, hence, no valid test is performed.

The best way to solve this would be by changing MINIMUM_ALLOWED_NUMBER_CLASSES definition so it can correspond to the NON-OTHER number of classes a taxonomy has. I.e., only classifications different than "other" are counted.

@pedropaulofb pedropaulofb added the enhancement New feature or request label Jan 19, 2023
@pedropaulofb pedropaulofb self-assigned this Jan 19, 2023
@pedropaulofb
Copy link
Collaborator Author

@mozzherina, please note that for now you have no action regarding this issue. It is assigned to me and I'll work on it in February. After closing this issue, I'll create another one regarding its implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant