-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard Feature Review #1420
Comments
|
Great thanks @sheralim012 the rows issue seems like it won't be a problem. Re datasets, here are the user stories which describe the problem: As an IoGT PLATFOR ADMIN (eg at CO) I want to be able to press a button in IoGT which will create a Superset dashboard based on a questionnaire. As an IoGT PLATFORM ADMIN I want to be able to view and modify the resulting dashboard and charts, and give access/modification permissions to other users. As an IoGT PROJECT LEAD (eg me, my team, etc) I want to have access view, modify, and change permissions on all datasets, dashboards and charts. As an IoGT PROJECT LEAD I want for each IoGT PLATFORM ADMIN to ONLY have access to dashboards, charts, and datasets that correspond to their IoGT platform (unless I manually change permissions in Superset). This is to keep the environment clean for users. As an IoGT PROJECT LEAD I want for each IoGT PLATFORM ADMIN to ONLY have access to use data within datasets, not to create datasets (unless I manually give permission). This is to protect against creating datasets from queries which are disruptive to the production database or don't incorporate the questionnaire-level permissions from Django (if we are implementing those through the dataset queries). As an IoGT PROJECT LEAD I want for each IoGT PLATFORM ADMIN to NOT have access to change dataset configurations (unless I manually give permission). This is to prevent removal of the incorporated questionnaire-level permissions from Django (if we are implementing those through the dataset queries). The key problem here is that a user needs to create a dataset via the automated dashboard function, but they also should not have permission to create a new dataset manually or edit existing datasets because that will allow them to sidestep query-based permissions structure. Also - right now we only allow admins to use the dashboard tool, but longer-term this should be part of a lower-permission Analyst role, which may have access to questionnaire data only and not the rest of the platform database. One possible way around this would be implementing the permissions query I designed combined with Jinja through Row Level Security, but I don't believe it's possible as RLS is only a WHERE statement. Jinja may also not work in RLS. Another possible way is by having a "helper" system user (like we use for RapidPro integration). That user has permission to write datasets, and then gives access to the human user that created the dataset, who has read permission for datasets. Most likely that dataset access permission is done through roles eg giving access to that dataset to "IoGT Zambia Admin" "IoGT Zambia Analyst" roles which are manually assigned to Superset users. |
Needed before for MVP approval
Changes needed after MVP
The text was updated successfully, but these errors were encountered: