slashes confuse the checker?

[srl295]

over on unicode-org/cldr#1085 the following text failed both PR title and Commit title validation:

• CLDR-14395 /api/auth endpoints

with "PR must begin with a Jira ticket ID" etc.

Changing to CLDR-14395 API for … fixed it. Something with slashes?

[sffc]

The following regex is used:

jira-github-pr-check/app.js

Line 16 in f1863db

const JIRA_COMMIT_PATTERN = /^([A-Z]+-\d+)\u0020\w/;

So it's looking for a \w. This is to ensure that there's something besides whitespace following the Jira ticket number.

Suggestions for a better regex? Unicode letter property? (That won't fix the slash problem.) Maybe just \S?

[markusicu]

How about

const JIRA_COMMIT_PATTERN = /^([A-Z]+-\d+)\u0020\w/;

-->

const JIRA_COMMIT_PATTERN = /^((CLDR|ICU)-\d+) [\p{L}\p{N}\p{P}\p{S}]/u;

If \p{L} does not work, try \p{gc=L}.

[macchiati]

LGTM Mark

…

On Fri, Mar 5, 2021 at 3:46 PM Markus Scherer ***@***.***> wrote: How about const JIRA_COMMIT_PATTERN = /^([A-Z]+-\d+)\u0020\w/; --> const JIRA_COMMIT_PATTERN = /^((CLDR|ICU)-\d+) [\p{L}\p{N}\p{P}\p{S}]/u; If \p{L} does not work, try \p{gc=L}. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#30 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACJLEMDWSZTMWQOOSHFKEQTTCFULXANCNFSM4YTYBY5Q> .